most efficient way to get 4

3 Posts

xdom01 Reply #1, 15 years, 1 month ago

Hi,

I need to get the value of 4 template variables and have some code that deals with it, depending on the values. I have read quite a bit of stuff about template variables, but I am not really closer to the most efficient way of doing this. I realise that the php code can be neater and more generic etc but at this stage, I am more concerned about the most efficient way to get the template variables' values to do this. Are there any suggestions for improvements on the below snippet code?

<?php
for($i=1;$i<=4;$i++){
	$tv = $modx->getObject('modTemplateVar', array('name'=>'hp-col' . $i . 'Title'));
	$aValues[$i]['title'] = $tv->getValue(1);
	$tv = $modx->getObject('modTemplateVar', array('name'=>'hp-col' . $i . 'Link'));
	$aValues[$i]['link'] = $tv->getValue(1);
	$tv = $modx->getObject('modTemplateVar', array('name'=>'hp-col' . $i . 'Image'));
	$aValues[$i]['image'] = $tv->renderOutput(1);
}
$aReturn	=	array();
$aReturn[]	=	'<ul>';
for($i=1;$i<=4;$i++){
	if($aValues[$i]['title'] != ""){
		$aReturn[]	=	'<li' . ($class != '' ? ' class="' . $class . '"' : '') . '>';
		if($aValues[$i]['link'] != ""){
			if(strstr($aValues[$i]['link'], 'http')){
				$aReturn[]	=	 '<h2><a href="' . $aValues[$i]['link'] . '">' . $aValues[$i]['title'] . '</a></h2>';
				$aReturn[]	=	 '	<div class="imgholder"><a href="' .  $aValues[$i]['link'] . '">' .  $aValues[$i]['image'] . '</a></div>';
				$aReturn[]	=	 '	[[*hp-col' . $i . 'Content]]';
			}else{
				$aReturn[]	=	 '<h2><a href="[[~[[*hp-col' . $aValues[$i]['link'] . 'Link]]~]]">' . $aValues[$i]['title'] . '</a></h2>';
				$aReturn[]	=	 '	<div class="imgholder"><a href="[[~[[*hp-col' .  $aValues[$i]['link'] . 'Link]]~]]">' . $aValues[$i]['image'] . '</a></div>';
				$aReturn[]	=	 '	[[*hp-col' . $i . 'Content]]';
				$aReturn[]	=	 '	<p class="readmore"><a href="[[~[[*hp-col' . $i . 'Link]]~]]">Read more about \'[[*hp-col' . $i . 'Title]]\'</a></p>';
			}
		}else{
			$aReturn[]	=	 '	<h2>' . $aValues[$i]['title'] . '</h2>';
			$aReturn[]	=	 '	<div class="imgholder">' . $aValues[$i]['image'] . '</div>';
			$aReturn[]	=	 '	[[*hp-col' . $i . 'Content]]';

- 24,544 Posts
BobRay Reply #2, 15 years, 1 month ago
Your code seems to have been cut off at the bottom, so it's hard to see what you need.

A few of points, though:

First, it's always faster to get objects by ID than by name.
```
$modx->getObject('className', 12);
```
So if you know the ID of each TV, that will speed things up.

Second, for TVs where you don't need renderOutput(), you don't really need to get the TV object. You can get the TemplateVarResource object directly, which contains the TV's ID, the Resource ID, and the TV Value. It might also be possible (or not) to redo your image TV so that you put the HTML in the output rather than in the TV (i.e., the TV will just contain the URL of the image). If the TV contains the Alt value and size info, that probably won't work, though, but you could still do this for the other TVs.
```
$tvId = 12;
$resourceId = 33;

$tvr = $modx->getObject('modTemplateVarResource', array ('tmplvarid'=>$tvId, 'contentid'->$resourceId));
$value = $tvr->get('value');
```
Also, if the return value doesn't have to be an array, it might be faster to just set one string with "\n" for the line breaks.

You might also look into using one or more Tpl chunks with placeholders:
```
$modx->getChunk('chunkName', $placeholderArray);
```
getChunk is quite fast and moving the HTML into a chunk will make it *way* easier to maintain.

Finally, it's hard to tell from the code, but a switch statement might be more efficient and easier to read and maintain. [ed. note: BobRay last edited this post 15 years, 1 month ago.]
Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting