Quip Latestcomments Family type showing unapproved comments

67 Posts

jimbob72 Reply #1, 12 years, 8 months ago

I have Quip 2.0.4 installed on Revolution 2.1.3pl. I am using Quip Latestcomments on several pages and all comments require approval.

Where I use latestcomments without a type, only approved comments are displayed. However, where i use type=`family`, the comments displayed include unapproved ones.

Does anyone have any idea why this is?

Thanks

67 Posts

jimbob72 Reply #2, 12 years, 8 months ago

I've worked it out. If you use the type function, the check to see if comments are approved is ignored. The code in snippet QuipLatestComments (lines 97-99) needs to be amended to:

$c->where(array(
    'quipComment.deleted' => false,
//new line here to check approval	
'quipComment.approved' => true,
));

I will add this as a bug in Github

4,149 Posts

splittingred Reply #3, 12 years, 8 months ago

Good catch! Can you file that here: http://bugs.modx.com/projects/Quip ? Thanks!

shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com