Site users/managers with access to photo manager

Yeh, this problem has been bugging me for a while also (I’ve been hacking in the allowed manager group IDs for several versions now)...

@ZAP
Have you fixed the sql queries in the checkPermissions function? I haven’t had time/energy to do MaxiGallery lately, but I hope to pickup the slack this weekend.. If you have already fixed that, I’d be interested to see your suggestions..

Do you mean the mod posted in this thread?
http://modxcms.com/forums/index.php/topic,7449.0.html

I haven’t done that, no. In fact I haven’t really looked for a solution because I only just realized that it might be a Maxigallery bug and that I should look there for answers. Previously I just thought that something was fishy in the overall MODx user authentication system and figured that it would be fixed in future versions (or that I wasn’t setting it up properly, since it never quite works the way I expect).

EDIT: I’m looking now at the code in the version of maxigallery.class.inc.php that I’m using (which came with MG 0.5 BETA 2), and the checkPermissions seems to already have the fix above provided by TobyL...

What I’d really like to work on is a gallery admin module that works outside of the document preview window (or the document itself). I don’t personally ever use the admin functions outside of the Manager, and this seems as if it would be less confusing for people. I think that I saw this on your to-do list a while back, but I know that your list is long and there are probably more pressing things on it.

The other tool that I’m going to create as a module is a batch image processor/importer. A site I’m helping out with has several galleries of 800 or more photos, and it would really make their lives easier to be able to upload big versions of all the images in a gallery and then have the batch tool process and add them to the database (with sequential titles). If you like I’ll send it to you when it’s done so that you can see if you think it’s a useful addition and if so improve and share it (perhaps it could be turned into a sort of DocManager for MG).

And I guess while I’m off on this tangent, I’ve used MG as the basis for several eCard scripts in the last year or so, and that seems like something that might be worth cleaning up and making available as a MG mod...

OK now I’m realizing that the problem may in fact be operator error...

I think that I am fundamentally confused between manager ROLES and manager USER GROUPS. Is it me, or do other people have trouble with this as well? I swear it makes me feel like an idjut every time I set these up...

Basically I had created a manager role and not a user group (with a linked document group). When I did the latter, put the gallery pages in this group, and added that group name to the $manager_webgroups array it now allows those users to manage images on those pages. I also had to add the ability to change document access permissions to that manager role so that these users can create new gallery pages that they can edit.

So my question now is: Would I still have to do all this if I upgraded this site to 0.9.5? They have been resisting me on that because they say that they’ve just gotten the hang of 0.9.2 and they don’t want to make a big change now, but eventually I’m gonna back them into a corner and make them update. I would love it if any user who can edit a document could automatically also manage the images in that document’s galleries without having to jump through so many hoops.

Users are who you are, groups are a group of users. By themselves, they don’t say anything about what you can do, they simply provide identity.

Documents can also be put in document groups, and then only members of a user group connected to a document group can access them. This applies to both manager users/groups and web users/groups. Again, this says nothing about what you can do to what you can access.

Roles are what you, as an individual manager user, can do in the Manager.

So groups control access, both manager and web. Roles control actions for individual manager users.

Snippets control actions in their code, either by group, or simply by login status.

Quote from: ZAP at Jan 24, 2007, 05:44 PM

Do you mean the mod posted in this thread?
http://modxcms.com/forums/index.php/topic,7449.0.html

No, this is already in MaxiGallery as you noticed, but it’s not enough for a proper fix..

Quote from: ZAP at Jan 24, 2007, 10:09 PM

I would love it if any user who can edit a document could automatically also manage the images in that document’s galleries without having to jump through so many hoops.

Yes, this is the problem with the checkPermissions, currently it checks that is the user in admin role or does the user have rights to edit the document per document group basis.. but it doesn’t notice that if the document is not attached to any document groups but the user has a role that still has the rights to edit those documents.. that is what needs to be fixed.

Quote from: ZAP at Jan 24, 2007, 05:44 PM

What I’d really like to work on is a gallery admin module that works outside of the document preview window (or the document itself). I don’t personally ever use the admin functions outside of the Manager, and this seems as if it would be less confusing for people. I think that I saw this on your to-do list a while back, but I know that your list is long and there are probably more pressing things on it.

The other tool that I’m going to create as a module is a batch image processor/importer. A site I’m helping out with has several galleries of 800 or more photos, and it would really make their lives easier to be able to upload big versions of all the images in a gallery and then have the batch tool process and add them to the database (with sequential titles). If you like I’ll send it to you when it’s done so that you can see if you think it’s a useful addition and if so improve and share it (perhaps it could be turned into a sort of DocManager for MG).

I actually have alot for that batch uploader done already.. I have a module for it and a javascript that "assigns" pictures from certain directory/directories from the server to certain galleries.. But they are not patched together yet.. If you want to work on them, I’ll be happy to send them to you.

Quote from: ZAP at Jan 24, 2007, 05:44 PM

And I guess while I’m off on this tangent, I’ve used MG as the basis for several eCard scripts in the last year or so, and that seems like something that might be worth cleaning up and making available as a MG mod...

Yea, could be useful to have in the resource repo.. but if I can choose that would you do this or to clean the shopx modifications that you have done to it (what I’ve read from shopx thead), I would prefer to see the later

That may be the first time that the difference between roles and groups has ever really made sense to me - thanks!

The permission things should be now fixed in SVN code, just to let you know..

THANKS!