eform broken in MODx 0.9.6RC2 ?

53 Posts

lmestre Reply #1, 19 years, 5 months ago

I’ve just updated two sites in development (previously running 0.9.6RC1) with MODx 0.9.6RC2.

Everything is fine but the contact page with an eForm call is simply blank (no output at all). The same thing happens on the two sites.

If I remove the eForm call from the page, it shows up correctly without the form. It was all fine with 0.9.6RC1.

Anybody having the same problem ? Any idea what to do to fix it ?

Thanks

53 Posts

lmestre Reply #2, 19 years, 5 months ago

Note that I rolled back to the eform found in MOD 0.9.6 RC1 and it is working fine.

There is definitely something weird with eForm in RC2.

7,075 Posts

davidm Reply #3, 19 years, 5 months ago

I didn’t encounter this issue but my guess is your eForm call was written for a previous eForm version and it got updated to eForm 1.4.4 with possibly different syntax or whatever. Maybe start from here...

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

53 Posts

lmestre Reply #4, 19 years, 5 months ago

Thanks David.
Following your advice I played a bit with the parameters and I found the one causing my problem. It is &cssStyle.

Here is my call:

[!eForm? &formid=`ContactForm` &tpl=`ContactForm` &to=`[email protected]` &gotoid=`17` 
&cssStyle=`assets/templates/form.css` &requiredClass=`error` &invalidClass=`error` 
&report=`ContactFormReport` &subject=`blahblah` !]

With cssStyle the page output is blank. Without it, the page output contains the unstyled form.

Problem is that cssStyle is not deprecated or changed in eForm 1.4.4 as far as I know and should work I guess ?

MODX Staff
12,272 Posts

Ryan Thrash Reply #5, 19 years, 5 months ago

That’s a great question. I don’t think it should be.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

1,010 Posts

TobyL Reply #6, 19 years, 5 months ago

Quote from: lmestre at Apr 16, 2007, 09:10 AM

With cssStyle the page output is blank. Without it, the page output contains the unstyled form.

Problem is that cssStyle is not deprecated or changed in eForm 1.4.4 as far as I know and should work I guess ?

Problem found... copy and paste error on line 1092 sad

You were probably seeing a blank page because the error messages are suppressed, otherwise you would have noticed a parse error

Attached is a corrected version of eform.inc.php

EDIT: Replaced corrupted zip file,.. that is, ~~I tried to. Somehow the upload is corrupted again, I’ll zip it up differently next~~
Trying again...

fifth try, no luck again! Can’t seem to upload anything properly... please have a try at this one but I fear it’s corrupted again...

eForm | eForm support | eForm @ wiki

MODX Staff
12,272 Posts

Ryan Thrash Reply #7, 19 years, 5 months ago

Hi Jelle,

.zip is corrupt for me here. :/ What’s the error on 1092?

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

53 Posts

lmestre Reply #8, 19 years, 5 months ago

corrupted for me too.

1,010 Posts

TobyL Reply #9, 19 years, 5 months ago

Sorry about that, I’ll upload a new one a little later.. Error is in efLoadTemplate() function. The line

//<?php
if(!$tpl) $tpl = ( $doc=$this->modx->runSnippet($key) )? $doc : false;
//?>

should be:

//<?php
if(!$tpl) $tpl = ( $doc=$modx->runSnippet($key) )? $doc : false;
//?>

I ported it back from the class-ified version I’m working on but off course there is no $this in this version.

eForm | eForm support | eForm @ wiki

53 Posts

lmestre Reply #10, 19 years, 5 months ago

Thanks Jelle,

This change does fix my problem.