We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 24719
    • 194 Posts
    The regular expression that removes the eform attribute from tags needs tweaking. it doesn’t match eform attributes whose values contain a single quote (as part of a regular expression for instance).

    Great work though, i’m using it loads
      • 30223
      • 1,010 Posts
      No, that"s a feature... I don"t like single quotes! grin

      Thanks for pointing that out. I"m assuming you already made the change for yourself? Might as well post the solution smiley

      Anyway I’ll update it with the next version.
        • 24719
        • 194 Posts
        hmm, i can’t think of a good alternative now - unless we’re going for xhtml in which case just lose the single quotes from the current regexp
          • 30223
          • 1,010 Posts
          Hmm,... there is a simple option which will work I just realized. (I actually used it in the form parse function). Try replacing the expression on line 538 with:
          $regExpr = "#eform=([\"'])[^\\1]*?\\1#si";
          


          Basically it now only matches between equal quotes, so either between ’ and ’ or between " and ". but not between " and ’ or the other way around.

          This will for instance match something like:
          eform="Myform::1::#REGEX /’[^’]*?’/i" or eform=’Myform::1::#REGEX /"[^"]*?"/i’


            • 24719
            • 194 Posts
            hi jelle,

            This didn’t make it into the codebase. 1.4.4 still has an old regexp which gets confused with single quotes. This one works though.
              • 30223
              • 1,010 Posts
              Thanks for alerting me! I’ll update the code pronto.