We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
MODX Community Forums Archive

TinyMCE 3.3.2 IE7 support fix

    • 16610
    • 634 Posts
    Lammikko Reply #1, 16 years, 5 months ago
    Just noticed that TinyMCE 3.3.2 shipped with MODx 1.0.3 is broken with IE7. RTE doesn’t load at all with IE7.

    How to fix it:

    1. Open "\assets\plugins\tinymce\js\mce_init.js.inc" and replace lines 30 and 53:

    Line 30: 
    alignfull : {selector : 'p,h1,h2,h3,h4,h5,h6,td,th,div,ul,ol,li,table,img', classes : 'justifyfull'}

    Line 53: 
    onchange_callback : [+onchange_callback+]


    2. Open "\assets\plugins\tinymce\tinymce.functions.php" and replace line 161 with this (fixes custom params):

    $ph['customparams'] = (!empty($params['customparams'])) ? ','.$params['customparams'] : '';


    That’s it.
      Mikko Lammi, Owner at Maagit
      • 16610
      • 634 Posts
      Lammikko Reply #2, 16 years, 5 months ago
      Would have added this to JIRA too but it seems TinyMCE version 3.3.2 is missing from "Affects Versions" list (only 3.2.4.1 and 3.2.7.0-rc1).
        Mikko Lammi, Owner at Maagit
        • 16610
        • 634 Posts
        Lammikko Reply #3, 16 years, 5 months ago
        More testing with IE7...

        It seems TinyMCE 3.3.2 has also problems with QuickManager+ if you align images left or right by using a class when using IE7. Modal box misplaces itself. This problem has nothing to do with MODx though. It’s caused by the new TinyMCE 3.3.x version branch.
          Mikko Lammi, Owner at Maagit
          • 25663 MODX Staff
          • 12,272 Posts
          Ryan Thrash Reply #4, 16 years, 5 months ago
          Log the tiny bugs against the main project since it’s being distributed with it for the time being anyway.
            Ryan Thrash, MODX Co-Founder
            Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
            • 16610
            • 634 Posts
            Lammikko Reply #5, 16 years, 5 months ago
            Thank you for the clarification. I created two tickets in JIRA:

            - TinyMCE 3.3.2 not showing up in IE7: http://svn.modxcms.com/jira/browse/MODX-1840
            - Using IE7 and TinyMCE 3.3.2 image align not working properly with QuickManager+: http://svn.modxcms.com/jira/browse/MODX-1841
              Mikko Lammi, Owner at Maagit
              • 33014 ☆ A M B ☆
              • 1,231 Posts
              yama Reply #6, 16 years, 5 months ago
              In my environment, I was not usable by the method that Lammikko suggested.

              my method
              onchange_callback : [+onchange_callback+][+end_comma+]

              $ph[’end_comma’] = (!empty($params[’customparams’])) ? ’,’ : ’’;
              $ph[’customparams’] = rtrim($params[’customparams’], ’,’);

              http://code.google.com/p/modx-ja/downloads/detail?name=tinymce332r6.zip
                • 25519
                • 265 Posts
                rootsdiv Reply #7, 16 years, 5 months ago
                @Lammikko - I applied these fixes but nothing has changed at all unfortunately. Have checked in ie6,7 & 8, FF, Opera, Chrome, Safari, and all have the same result, no RTE. I force-refreshed browser cache each time before logging in, so I should be seeing all correctly.

                I opened tinymce.functions.php in DW CS4 and line 32 is highlighted as invalid due to duplicate attribute, so I altered it to the following:
                $themeOptions .= '<option value="">' . $key . '"' . ($key == $params['theme'] ? ' selected="selected"' : '') . '>' . $value . '</option>' . PHP_EOL;

                Uploaded but still no RTE ...

                In the plugin System Events, currently applied are:
                - Template Service Events: OnLoadWebDocument
                - RichText Editor: OnRichTextEditorInit, OnRichTextEditorRegister
                - System Settings: OnInterfaceSettingsRender

                Would a rollback to an earlier version help?

                Could really do with some advice here please.
                Many thanks in advance
                  • 16610
                  • 634 Posts
                  Lammikko Reply #8, 16 years, 5 months ago
                  If TinyMCE isn’t working for you with any browser I don’t think this fix will fix your problem. It must be something else. I have only experienced problems with TinyMCE 3.3.2 and IE7. With other browsers it works fine for me. Have you tried uploading all TinyMCE files again in case of corrupted file?
                    Mikko Lammi, Owner at Maagit
                    • 25519
                    • 265 Posts
                    rootsdiv Reply #9, 16 years, 5 months ago
                    That doesn’t work, tried in multiple browsers. I’m gonna try with uploading an older version, will let you know how that goes.
                    Thanks
                      • 25519
                      • 265 Posts
                      rootsdiv Reply #10, 16 years, 5 months ago
                      I rolled the version back to v3241 from Evo 102 and the RTE appears again ... but resource browser has wrong colour background and I can’t insert images - can work through directories in the browser but not insert images.

                      I’m gonna roll the whole install back and try upgrading to Evo103 but without the TinyMCE upgrade.

                      will let you know how that goes.
                      Thanks