We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 29357
    • 35 Posts
    Dear Stefan

    Fantastic Plugin which clearly is the result of hundreds of hours of work.

    I found a small bug in the rev_details_content.tpl.phtml (I believe the rev_details_content_tabbed.tpl.phtml is unused)
    Line 26 onwards should be:

       <?php if( $_rev['ch_diff_content'] ): ?>
       <div class="tab-page" id="ch-content-tabpage-diff-<?php echo $_rev['ch_doc_rev']; ?>">
            <h2 class="tab"><?php echo $ch->txt('Unterschiede zur aktuellen Version'); ?></h2>
            <script type="text/javascript">chContent.addTabPage( document.getElementById( 'ch-content-tabpage-diff-<?php echo $_rev['ch_doc_rev']; ?>' ) );</script>
            <div>
                <?php echo $_rev['ch_diff_content']; ?>
            </div>
       </div>
       <?php endif; ?>
    


    Previously it had id="ch-content-tabpage-source-<?php echo $_rev[’ch_doc_rev’]; ?>" as the id which was the same as the div above. This causes javascript errors in IE if there is more than one page version.

    I notice that many of the template calls are in accented German. Whilst this is clearly your mother tongue, for distros in the rest of the world and moving back and forth from utf8 to 8859 this may cause problems with corruption. For me in utf8 they look like binary. It would be nice (for us even if not you!!) if you could avoid using umlauts in code!!

    Wishlist:
    I have also seen a commented out draftmode on/off div in content_history, which I would like to get going. In my application (as many other users I expect) some individuals do not have publish rights, so their page saves must go straight to history and not immediately be published as the newest version.  Only admins should be able to restore or publish these versions.

    I have several content column areas in my pages, provided by TVs. I notice that the system works well with these already but the commented out div (Which I have uncommented) "Snippets werden nicht geparst" is cut off so the full preview cannot be seen. This too will be an excellent feature and it would be nice of the parsed content could be made to show the parsed content of TVs too.

    Julian, Auckland NZ

      • 13300
      • 5 Posts
      Quote from: stefan at Jan 14, 2009, 02:59 AM

      Hello Jonez,

      thanks for your message.

      You are using xampp/wampp with exactly the same setting like terry. It’s your local environment, right? Have to tried to install it on a live-Server? Maybe a part of xampp/wampp is causing this error.

      At the moment the download of the current xampp is running, later this day i will test it with it and report what happened.

      adios, Stefan



      Yes, this is my local environment - in which case it’s not important that it works correctly - I have installed in on a couple live-Servers (one running NT and one Linux) and it works great! - It’s probably my personal wamp installation that has some weird setting - I had gutted IIS (which was running previously) to get WAMP up and running. I’m deffinitely not a SYSadmin. Thanks!
        • 29357
        • 35 Posts
        Dear Stefan

        Is the draft mode likely to be available sometime soon. I have people pressing me for that as it adds a real workflow to Modx V0.9.3 which is missing. How might I implement whats there already?

        Julian
          • 1343 ☆ A M B ☆
          • 2,213 Posts
          I finally got around to installing CH on a test site and it seams to be working very well, but I do have one problem in that most of the front end text isn’t english. Before I hit up google translate can anyone tell me if there is some setting I should have flipped to get english?

          Also the show/hide icon isn’t a toggle switch is there any chance that it could be setup that way instead of forcing us to click the text?

          Thanks,
          AMDbuilder
            Patrick | Server Wrangler
            About Me: Website | Tweets |  MODX Hosting
            • 28436
            • 242 Posts
            Hello Guys!

            Iam not dead, i still alive but needed a break... and got it. Now iam back with new heart and motiviation.

            Sorry for all the unanswered questions:

            Dear rasc:
            I use my own mm based on mootools, so i was not able to reproduce your errors. But there is a hint in the mm-docu somthing like "mm will not work with other plugins that use mootools".

            All the diffent version of xampp:
            I tried it on tree different Versions of xampp and seven different Browsers/Versions Opera(9),Safari,IE(6,7,8b),FF but all on windows. Nothing found...

            Julian:

            At first: Thanks a lot for your suggestions about the same id for the container. Its done.

            You can also fix it by a smart way.

            just create a new folder /skin/julian/tpl/chunks/
            copy the file to it /skin/julian/tpl/chunks/rev_details_content_tabbed.tpl.phtml

            fix the lines and than go to the plugin page -> config and set the switch "skin" from "default" to "julian"
            Now your fixed file will load instead the original from "default". All other files will get from the default directory if they not exists in your namespace(directory "julian")


            Ok, what up with the translations:

            It would be nice (for us even if not you!!)
            hehehe right right right

            if you could avoid using umlauts in code!!
            aaarrrrrrgggnoooooo ...... utf8 is made for this kind of bullshit... but ok, i see, i implement a parameter zu setup the encoding btw. use the manager-config for it.

            the translations are based(or should based) on a .txt file called as your manager-language is within the directory /lang/
            eg: english.txt, french.txt and so on. german.txt is not needed because the native language of the messages is already german.
            Just copy the english.txt and change it to your needs.

            if there a problem with the encoding, use on of the files i attached and change it.


            draftmode:
            It is already working in my current developversion, but iam not sadisfy with it, not with the functionality... with the code behind it. looks too ugly.

            Rights :
            Only admins should be able to restore or publish these versions.

            Yes, this is a "must go". And it will go.

            Full document/draft (pre)view:

            [...] but the commented out div (Which I have uncommented) "Snippets werden nicht geparst" is cut off so the full preview cannot be seen.
            Yes, i know. It means "snippets will not parsed". Forget this bullshit ....

            would be nice of the parsed content could be made to show the parsed content of TVs too.

            ... because there is a real preview. With the abiliy to surf through the diffrent versions( see the screenshots)

            I already said it. I got new motivation and so i will finish this step as soon as possible.

            But after this step i need help to bring it forward.

            The reason is simple: I can’t stay the hole fucking day at this damnit machine.
            If i do, i will get into trouble with my girlfriend and my life itself.
            So i made the desicion to spend more time with my "reallife" friends

            Looking into eyes while drinking beer in the evening sun... do you remember this feeling?

            adios, Stefan


              • 28436
              • 242 Posts
              another screen
                • 24495
                • 407 Posts
                Glad to seeread you back here.
                But there is a hint in the mm-docu ...
                Must look at this next week, thanks for reply and the tip.

                EDIT: looked into the doc but can’t find anything about this except
                ManagerManager is not compatible with Manager plugins which use Mootools library, including ShowImageTVs. It is suggested that you disable the ShowImageTVs plugin, and use the mm_widget_showimagetvs widget instead

                No solution found in doc or forum. What about your mootools based version?
                  • 29357
                  • 35 Posts
                  Dear Stefan,

                  I know what you mean... I am now looking at the sunset at the end of summer ( I am in New Zealand). You can spend too much time on the computer and it can cost you girlfriends (or wives in my case). I talk from bitter experience.

                  I can help if you want and would like to see the preliminary draft code if possible. My latest site is a New Zealnad premier ISP for whom I work. Thats the one that needs draft. I also have quite a few private sites, mostly modx, but some coldfusion.

                  As for Deutsch and utf8 I was only referring to code comments which somehow, despite the best intentions, get scrambled by going through 8859 somewhere in the process across various machines. I had it happen recently using a YAML template (I love YAML) and I had a core file blow out to 33Mb due to some bizarre corruption possibly associated with some non utf8 part of the path.

                  Julian
                    • 1343 ☆ A M B ☆
                    • 2,213 Posts
                    I would be more than happy to help test draft mode and/or user control as I have a few sites that would die for drafting abilities! Also any ideas when we might expect to see this draft enabled version emerge?

                    Thanks,
                    AMDbuilder
                      Patrick | Server Wrangler
                      About Me: Website | Tweets |  MODX Hosting
                      • 7231
                      • 4,205 Posts
                      The drafting options looks great. Good work grin
                        [font=Verdana]Shane Sponagle | [wiki] Snippet Call Anatomy | MODx Developer Blog | [nettuts] Working With a Content Management Framework: MODx

                        Something is happening here, but you don&#39;t know what it is.
                        Do you, Mr. Jones? - [bob dylan]