UpdateProfile Security - How do I lock certain fields from user input?

Quote from: Oleg at Feb 14, 2011, 05:10 AM

Thanks for the code, I’ll try it out. Git is still on my to-learn list, though .

Git is a stern mistress at first, but once you get used to it, you can’t live without it.

The guide is here: http://rtfm.modx.com/display/community/MODx+GitHub+Contributor%27s+Guide

You would be forking this repo: https://github.com/splittingred/Login rather than the modx repo (once you have a GitHub account, just go there and click on the Fork button), and then cloning it like this:



Of course you’d also have to have a Git client on your machine, which can be a challenge to set up, but you only have to do it once.

Thanks for the info. I’ll give it a go after I get the code tested. I did install Git successfully on my Windows computer, and I even created a GitHub account, but I have yet to do anything with it .

A quick note: I use extended fields, so I will modify your code slightly. Instead of &readOnly fields, I will use &allowedFields, and change it to if NOT in_array:



That way, users can’t just add a million extended fields. Not that someone would figure it out , but you never know....

I was thinking that most users would only want to restrict a small number of fields, but I see your point. You could have two parameters &allowedFields and &disallowedFields, but you’d have to make sure they weren’t both set and the code would get more complicated. As I said, I don’t use the snippet so it’s up to you.

[update] You should probably make sure that all fields are allowed if &allowedFields is empty.

You have a point. Maybe the best compromise would be &disallowedFields for NON-extended fields and &allowedExtended for extended fields. That way, both can be used at once, and it would allow anyone who doesn’t use extended fields to avoid the extra hassle.

Quote from: Oleg at Feb 14, 2011, 05:37 AM

You have a point. Maybe the best compromise would be &disallowedFields for NON-extended fields and &allowedExtended for extended fields. That way, both can be used at once, and it would allow anyone who doesn’t use extended fields to avoid the extra hassle.

If you do it that way, I would expect some confused and/or annoyed users. Personally, I would have both apply to all fields and just throw an error if the user sent both parameters (and allow all fields if neither was sent). Just my $.02.