WebSignup issues - missing username

- 270 Posts
lokust Reply #1, 19 years, 2 months ago

Hi, I can’t seem to get the form signup page to work. This is my call:

[!WebSignup? &tpl=`FormSignup` &useCaptcha=`0` &groups=`Registered Users`!]

The signup page, displays with Captcha although set to off and when the form is filled in and submitted, I get a javascript pop-up "missing username, please enter a username" even though all fields are completed.

Any ideas?

Thanks.
- 2 Posts
X Reply #2, 19 years, 1 month ago

i’m having exactly the same problem, can anybody suggest anything?
- 2 Posts
X Reply #3, 19 years, 1 month ago

Quote from: Uncle68 at May 29, 2007, 03:26 AM

Quote from: Mr. at May 28, 2007, 06:41 PM

I installed 0.9.6 today, and when I go to create a new user through the web signup form, for the blogs, it will not create a web user,
it just pops up an error: "Missing user name. Please insert a user name"

This is a bug, see http://modxcms.com/forums/index.php/topic,14253.msg97219.html#msg97219

Easy to fix (but hard to find out): just remove the wsu_ part of the names of the inputs in the template for the web signup.
But when that is done you will have problems if displaying the websignup form at the same time as displaying the side bar login form because there is a naming conflict.

Sorry for this confusing answer, it’s early here

I hope some one smarter than me will greate a new login system based on eForm, the current one is not really good. I tried to make a new one based on eForm, but came up with no good solution so far.

ahh, sweet sweet salvation!
2 Posts
DJGibbon Reply #4, 18 years, 9 months ago
Cheers for finding that X, "X"-ellent work (oh the comedy, it hurts)

To avoid conflicts with the login sidebar I amended the websignup.inc.php file to expect the wsu_ prefixed fields, this is marginally more robust (but might still cause maintainability issues)

Replacement code included below
<?php
# WebSignup 1.0
# Created By Raymond Irving April, 2005
# Edited by Phil Evans 16 December 2007 to expect wsu_ prefixed fields
#::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

defined('IN_PARSER_MODE') or die();

# load tpl
if(is_numeric($tpl)) $tpl = ($doc=$modx->getDocuments($tpl)) ? $doc['content']:"Document '$tpl' not found.";
else if($tpl) $tpl = ($chunk=$modx->getChunk($tpl)) ? $chunk:"Chunk '$tpl' not found.";
if(!$tpl) $tpl = getWebSignuptpl();

// extract declarations
$declare = webLoginExtractDeclarations($tpl);
$tpls = explode((isset($declare["separator"]) ? $declare["separator"]:"<!--tpl_separator-->"),$tpl);

if(!$isPostBack){
    // display signup screen
    $tpl = $tpls[0];
    $tpl = str_replace("[+action+]",$modx->makeURL($modx->documentIdentifier),$tpl);
    $tpl.="<script type='text/javascript'>
        if (document.websignupfrm) document.websignupfrm.wsu_username.focus();
        </script>";
    $output .= $tpl;
} 
else if ($isPostBack){

    $username = $modx->db->escape($modx->stripTags($_POST['wsu_username']));
    $fullname = $modx->db->escape($modx->stripTags($_POST['fullname']));
    $email = $modx->db->escape($modx->stripTags($_POST['wsu_email']));
    $password = $modx->db->escape($modx->stripTags($_POST['wsu_password']));
    $country = $modx->db->escape($modx->stripTags($_POST['country']));
    $state = $modx->db->escape($modx->stripTags($_POST['state']));
    $zip = $modx->db->escape($modx->stripTags($_POST['zip']));
    $formcode = $_POST['formcode'];

    // load template section #1
    $tpl = $tpls[0];
    $tpl = str_replace("[+action+]",$modx->makeURL($modx->documentIdentifier),$tpl);
    $tpl = str_replace("[+username+]",$username,$tpl);
    $tpl = str_replace("[+fullname+]",$fullname,$tpl);
    $tpl = str_replace("[+email+]",$email,$tpl);
    $tpl = str_replace("[+country+]",$country,$tpl);
    $tpl = str_replace("[+state+]",$state,$tpl);
    $tpl = str_replace("[+zip+]",$zip,$tpl);
    $tpl.="<script type='text/javascript'>if (document.websignupfrm) document.websignupfrm.wsu_username.focus();</script>";

    // check for duplicate user name
    if($username=="") {
        $output = webLoginAlert("Missing username. Please enter a user name.").$tpl;
        return;
    }
    else {
        $sql = "SELECT id FROM ".$modx->getFullTableName("web_users")." WHERE username='$username'";
        if(!$rs = $modx->db->query($sql)){
            $output = webLoginAlert("An error occured while attempting to retreive all users with username $username.").$tpl;
            return;
        } 
        $limit = $modx->db->getRecordCount($rs);
        if($limit>0) {
            $output = webLoginAlert("Username is already in use!").$tpl;
            return;
        }        
    }
    
    // verify email
    if($email=='' || !ereg("^[-!#$%&'*+./0-9=?A-Z^_`a-z{|}~]+", $email)){
        $output = webLoginAlert("E-mail address doesn't seem to be valid!").$tpl;
        return;
    }
    // verify password
    if ($_POST['wsu_password']!=$_POST['confirmpassword']) {
        $output = webLoginAlert("Password typed is mismatched").$tpl;
        return;
    }

    // check for duplicate email address
    $sql = "SELECT internalKey FROM ".$modx->getFullTableName("web_user_attributes")." WHERE email='$email'";
    if(!$rs = $modx->db->query($sql)){
        $output = webLoginAlert("An error occured while attempting to retreive all users with email $email.").$tpl;
        return;
    } 
    $limit = $modx->db->getRecordCount($rs);
    if($limit>0) {
        $row=$modx->db->getRow($rs);
        if($row['internalKey']!=$id) {
            $output = webLoginAlert("Email is already in use!").$tpl;
            return;
        }
    }

    // check password
    if (strlen($password) < 6 ) {
        $output = webLoginAlert("Password is too short!").$tpl;
        return;
    } 
    elseif($password=="") {
        $output = webLoginAlert("You didn't specify a password for this user!").$tpl;
        return;        
    }

    // verify form code
    if($useCaptcha && $_SESSION['veriword']!=$formcode) {
        $output = webLoginAlert("Incorrect form code. Please enter the correct code displayed by the image.").$tpl;
        return;
    }

    // create the user account
    $sql = "INSERT INTO ".$modx->getFullTableName("web_users")." (username, password) 
            VALUES('".$username."', md5('".$password."'));";
    $rs = $modx->db->query($sql);
    if(!$rs){
        $output = webLoginAlert("An error occured while attempting to save the user.").$tpl;
        return;
    }         
    // now get the id
    $key=$modx->db->getInsertId();

    // save user attributes
    $sql = "INSERT INTO ".$modx->getFullTableName("web_user_attributes")." (internalKey, fullname, email, zip, state, country) 
            VALUES($key, '$fullname', '$email', '$zip', '$state', '$country');";
    $rs = $modx->db->query($sql);
    if(!$rs){
        $output = webLoginAlert("An error occured while attempting to save the user's attributes.").$tpl;
        return;
    }

    // add user to web groups
    if(count($groups)>0) {
        $ds = $modx->dbQuery("SELECT id FROM ".$modx->getFullTableName("webgroup_names")." WHERE name IN ('".implode("','",$groups)."')");
        if(!$ds) return $modx->webAlert('An error occured while attempting to update user\'s web groups');
        else {
            while ($row = $modx->fetchRow($ds)) {
                $wg = $row["id"];
                $modx->dbQuery("REPLACE INTO ".$modx->getFullTableName("web_groups")." (webgroup,webuser) VALUES('$wg','$key')");
            }
        }
    }
            
    // invoke OnWebSaveUser event
    $modx->invokeEvent("OnWebSaveUser",
                        array(
                            "mode"         => "new",
                            "userid"       => $key,
                            "username"     => $username,
                            "userpassword" => $password,
                            "useremail"    => $email,
                            "userfullname" => $fullname
                        ));
                        
    // send email notification
    $rt = webLoginSendNewPassword($email,$username,$password,$fullname);
    if ($rt!==true) { // an error occured
        $output = $rt.$tpl;
        return;
    }
        
    // display change notification
    $newpassmsg = "A copy of the new password was sent to your email address.";
    $tpl = $tpls[1];
    $tpl = str_replace("[+newpassmsg+]",$newpassmsg,$tpl);    
    $output .= $tpl;
}

// Returns Default WebChangePwd tpl
function getWebSignuptpl(){
    ob_start();
    ?>
    <!-- #declare:separator <hr> --> 
    <!-- login form section-->
    <form method="post" name="websignupfrm" action="[+action+]" style="margin: 0px; padding: 0px;">
      <table border="0" cellpadding="2">
        <tr>
          <td>
          <table border="0" width="100%">
            <tr>
              <td>User name:*</td>
              <td>
              <input type="text" name="wsu_username" class="inputBox" style="width:300px" size="20" maxlength="15" value="[+username+]"></td>
            </tr>
            <tr>
              <td>Full name:</td>
              <td>
              <input type="text" name="fullname" class="inputBox" style="width:300px" size="20" maxlength="100" value="[+fullname+]"></td>
            </tr>
            <tr>
              <td>Email address:*</td>
              <td>
              <input type="text" name="wsu_email" class="inputBox" style="width:300px" size="20" value="[+email+]"></td>
            </tr>
            <tr>
              <td>Password:*</td>
              <td>
              <input type="password" name="wsu_password" class="inputBox" style="width:300px" size="20"></td>
            </tr>
            <tr>
              <td>Confirm password:*</td>
              <td>
              <input type="password" name="confirmpassword" class="inputBox" style="width:300px" size="20"></td>
            </tr>
            <tr>
              <td>Country:</td>
              <td><select size="1" name="country" style="width:300px">
                <option value="" selected> </option>
                <option value="1">Afghanistan</option>
                <option value="2">Albania</option>
                <option value="3">Algeria</option>
                <option value="4">American Samoa</option>
                <option value="5">Andorra</option>
                <option value="6">Angola</option>
                <option value="7">Anguilla</option>
                <option value="8">Antarctica</option>
                <option value="9">Antigua and Barbuda</option>
                <option value="10">Argentina</option>
                <option value="11">Armenia</option>
                <option value="12">Aruba</option>
                <option value="13">Australia</option>
                <option value="14">Austria</option>
                <option value="15">Azerbaijan</option>
                <option value="16">Bahamas</option>
                <option value="17">Bahrain</option>
                <option value="18">Bangladesh</option>
                <option value="19">Barbados</option>
                <option value="20">Belarus</option>
                <option value="21">Belgium</option>
                <option value="22">Belize</option>
                <option value="23">Benin</option>
                <option value="24">Bermuda</option>
                <option value="25">Bhutan</option>
                <option value="26">Bolivia</option>
                <option value="27">Bosnia and Herzegowina</option>
                <option value="28">Botswana</option>
                <option value="29">Bouvet Island</option>
                <option value="30">Brazil</option>
                <option value="31">British Indian Ocean Territory</option>
                <option value="32">Brunei Darussalam</option>
                <option value="33">Bulgaria</option>
                <option value="34">Burkina Faso</option>
                <option value="35">Burundi</option>
                <option value="36">Cambodia</option>
                <option value="37">Cameroon</option>
                <option value="38">Canada</option>
                <option value="39">Cape Verde</option>
                <option value="40">Cayman Islands</option>
                <option value="41">Central African Republic</option>
                <option value="42">Chad</option>
                <option value="43">Chile</option>
                <option value="44">China</option>
                <option value="45">Christmas Island</option>
                <option value="46">Cocos (Keeling) Islands</option>
                <option value="47">Colombia</option>
                <option value="48">Comoros</option>
                <option value="49">Congo</option>
                <option value="50">Cook Islands</option>
                <option value="51">Costa Rica</option>
                <option value="52">Cote D&#39;Ivoire</option>
                <option value="53">Croatia</option>
                <option value="54">Cuba</option>
                <option value="55">Cyprus</option>
                <option value="56">Czech Republic</option>
                <option value="57">Denmark</option>
                <option value="58">Djibouti</option>
                <option value="59">Dominica</option>
                <option value="60">Dominican Republic</option>
                <option value="61">East Timor</option>
                <option value="62">Ecuador</option>
                <option value="63">Egypt</option>
                <option value="64">El Salvador</option>
                <option value="65">Equatorial Guinea</option>
                <option value="66">Eritrea</option>
                <option value="67">Estonia</option>
                <option value="68">Ethiopia</option>
                <option value="69">Falkland Islands (Malvinas)</option>
                <option value="70">Faroe Islands</option>
                <option value="71">Fiji</option>
                <option value="72">Finland</option>
                <option value="73">France</option>
                <option value="74">France, Metropolitan</option>
                <option value="75">French Guiana</option>
                <option value="76">French Polynesia</option>
                <option value="77">French Southern Territories</option>
                <option value="78">Gabon</option>
                <option value="79">Gambia</option>
                <option value="80">Georgia</option>
                <option value="81">Germany</option>
                <option value="82">Ghana</option>
                <option value="83">Gibraltar</option>
                <option value="84">Greece</option>
                <option value="85">Greenland</option>
                <option value="86">Grenada</option>
                <option value="87">Guadeloupe</option>
                <option value="88">Guam</option>
                <option value="89">Guatemala</option>
                <option value="90">Guinea</option>
                <option value="91">Guinea-bissau</option>
                <option value="92">Guyana</option>
                <option value="93">Haiti</option>
                <option value="94">Heard and Mc Donald Islands</option>
                <option value="95">Honduras</option>
                <option value="96">Hong Kong</option>
                <option value="97">Hungary</option>
                <option value="98">Iceland</option>
                <option value="99">India</option>
                <option value="100">Indonesia</option>
                <option value="101">Iran (Islamic Republic of)</option>
                <option value="102">Iraq</option>
                <option value="103">Ireland</option>
                <option value="104">Israel</option>
                <option value="105">Italy</option>
                <option value="106">Jamaica</option>
                <option value="107">Japan</option>
                <option value="108">Jordan</option>
                <option value="109">Kazakhstan</option>
                <option value="110">Kenya</option>
                <option value="111">Kiribati</option>
                <option value="112">Korea, Democratic People&#39;s Republic of</option>
                <option value="113">Korea, Republic of</option>
                <option value="114">Kuwait</option>
                <option value="115">Kyrgyzstan</option>
                <option value="116">Lao People&#39;s Democratic Republic</option>
                <option value="117">Latvia</option>
                <option value="118">Lebanon</option>
                <option value="119">Lesotho</option>
                <option value="120">Liberia</option>
                <option value="121">Libyan Arab Jamahiriya</option>
                <option value="122">Liechtenstein</option>
                <option value="123">Lithuania</option>
                <option value="124">Luxembourg</option>
                <option value="125">Macau</option>
                <option value="126">Macedonia, The Former Yugoslav Republic of</option>
                <option value="127">Madagascar</option>
                <option value="128">Malawi</option>
                <option value="129">Malaysia</option>
                <option value="130">Maldives</option>
                <option value="131">Mali</option>
                <option value="132">Malta</option>
                <option value="133">Marshall Islands</option>
                <option value="134">Martinique</option>
                <option value="135">Mauritania</option>
                <option value="136">Mauritius</option>
                <option value="137">Mayotte</option>
                <option value="138">Mexico</option>
                <option value="139">Micronesia, Federated States of</option>
                <option value="140">Moldova, Republic of</option>
                <option value="141">Monaco</option>
                <option value="142">Mongolia</option>
                <option value="143">Montserrat</option>
                <option value="144">Morocco</option>
                <option value="145">Mozambique</option>
                <option value="146">Myanmar</option>
                <option value="147">Namibia</option>
                <option value="148">Nauru</option>
                <option value="149">Nepal</option>
                <option value="150">Netherlands</option>
                <option value="151">Netherlands Antilles</option>
                <option value="152">New Caledonia</option>
                <option value="153">New Zealand</option>
                <option value="154">Nicaragua</option>
                <option value="155">Niger</option>
                <option value="156">Nigeria</option>
                <option value="157">Niue</option>
                <option value="158">Norfolk Island</option>
                <option value="159">Northern Mariana Islands</option>
                <option value="160">Norway</option>
                <option value="161">Oman</option>
                <option value="162">Pakistan</option>
                <option value="163">Palau</option>
                <option value="164">Panama</option>
                <option value="165">Papua New Guinea</option>
                <option value="166">Paraguay</option>
                <option value="167">Peru</option>
                <option value="168">Philippines</option>
                <option value="169">Pitcairn</option>
                <option value="170">Poland</option>
                <option value="171">Portugal</option>
                <option value="172">Puerto Rico</option>
                <option value="173">Qatar</option>
                <option value="174">Reunion</option>
                <option value="175">Romania</option>
                <option value="176">Russian Federation</option>
                <option value="177">Rwanda</option>
                <option value="178">Saint Kitts and Nevis</option>
                <option value="179">Saint Lucia</option>
                <option value="180">Saint Vincent and the Grenadines</option>
                <option value="181">Samoa</option>
                <option value="182">San Marino</option>
                <option value="183">Sao Tome and Principe</option>
                <option value="184">Saudi Arabia</option>
                <option value="185">Senegal</option>
                <option value="186">Seychelles</option>
                <option value="187">Sierra Leone</option>
                <option value="188">Singapore</option>
                <option value="189">Slovakia (Slovak Republic)</option>
                <option value="190">Slovenia</option>
                <option value="191">Solomon Islands</option>
                <option value="192">Somalia</option>
                <option value="193">South Africa</option>
                <option value="194">South Georgia and the South Sandwich Islands</option>
                <option value="195">Spain</option>
                <option value="196">Sri Lanka</option>
                <option value="197">St. Helena</option>
                <option value="198">St. Pierre and Miquelon</option>
                <option value="199">Sudan</option>
                <option value="200">Suriname</option>
                <option value="201">Svalbard and Jan Mayen Islands</option>
                <option value="202">Swaziland</option>
                <option value="203">Sweden</option>
                <option value="204">Switzerland</option>
                <option value="205">Syrian Arab Republic</option>
                <option value="206">Taiwan</option>
                <option value="207">Tajikistan</option>
                <option value="208">Tanzania, United Republic of</option>
                <option value="209">Thailand</option>
                <option value="210">Togo</option>
                <option value="211">Tokelau</option>
                <option value="212">Tonga</option>
                <option value="213">Trinidad and Tobago</option>
                <option value="214">Tunisia</option>
                <option value="215">Turkey</option>
                <option value="216">Turkmenistan</option>
                <option value="217">Turks and Caicos Islands</option>
                <option value="218">Tuvalu</option>
                <option value="219">Uganda</option>
                <option value="220">Ukraine</option>
                <option value="221">United Arab Emirates</option>
                <option value="222">United Kingdom</option>
                <option value="223">United States</option>
                <option value="224">United States Minor Outlying Islands</option>
                <option value="225">Uruguay</option>
                <option value="226">Uzbekistan</option>
                <option value="227">Vanuatu</option>
                <option value="228">Vatican City State (Holy See)</option>
                <option value="229">Venezuela</option>
                <option value="230">Viet Nam</option>
                <option value="231">Virgin Islands (British)</option>
                <option value="232">Virgin Islands (U.S.)</option>
                <option value="233">Wallis and Futuna Islands</option>
                <option value="234">Western Sahara</option>
                <option value="235">Yemen</option>
                <option value="236">Yugoslavia</option>
                <option value="237">Zaire</option>
                <option value="238">Zambia</option>
                <option value="239">Zimbabwe</option>
                </select></td>
            </tr>
            <tr>
              <td>State:</td>
              <td>
              <input type="text" name="state" class="inputBox" style="width:300px" size="20" maxlength="50" value="[+state+]"></td>
            </tr>
            <tr>
              <td>Zip:</td>
              <td>
              <input type="text" name="zip" class="inputBox" style="width:300px" maxlength="50" size="20" value="[+zip+]"></td>
            </tr>
            <?php if ($useCaptcha){ ?>
            <tr>
              <td valign="top">Form code:*</td>
              <td>
              <input type="text" name="formcode" class="inputBox" style="width:150px" size="20">
              <a href="[+action+]"><img align="top" src="manager/includes/veriword.php?rand=<?php echo rand(); ?>" width="148" height="60" alt="If you have trouble reading the code, click on the code itself to generate a new random code." style="border: 1px solid #003399"></a>
              </td>
            </tr>
            <?php } ?>
            <tr>
              <td colspan="2"> * - Indicates required fields</td>
            </tr>
          </table>
          </td>
        </tr>
        <tr>
          <td align="right">
          <input type="submit" value="Submit" name="cmdwebsignup" />
          <input type="reset" value="Reset" name="cmdreset" />
          </td>
        </tr>
      </table>
    </form>
    <script language="javascript" type="text/javascript"> 
        var id = "[+country+]";
        var f = document.websignupfrm;
        var i = parseInt(id);
        if (!isNaN(i)) f.country.options[i].selected = true;
    </script>
    <hr>
    <!-- notification section -->
    <span style="font-weight:bold;">Signup completed successfully</span><br />
    Your account was successfully created.<br />
    A copy of your signup information was sent to your email address.<br /><br />
    <?php 
    $t = ob_get_contents();
    ob_end_clean();
    return $t;
}

?>