Err...actually, it’s not quite fixed. Here’s a suggestion that I think will work better:
In the original release of the output.class.inc.php file that is included with the 0.9.0 release, the links within the QE_menu_1 div had href values of "#". It looks like in your update that you simply removed the href’s altogether. Although this may work ok, it’s not exactly syntatically correct...nor is it valid. Instead, why not use this?:
<div id="QE_menu_1" class="collapsed">
<ul>
<li><a href="javascript:;" id="QE_ShowHide" onclick="QE_ShowHideLinks(true);" title="Show and hide the QuickEdit links">Show/Hide Links</a></li>
<li><a href="javascript:;" id="QE_Manager" href="{$managerPath}" title="Go to the MODx manager">Manager</a></li>
<li><a href="javascript:;" id="QE_Logout" href="{$logoutUrl}" title="Logout of your manager acount">Logout</a></li>
<li><a href="javascript:;" id="QE_Help" href="http://www.modxcms.com/quickedit.html" title="QuickEdit documentation on modxcms.com">Help</a></li>
</ul>
</div>
I also fixed the li tags as well. The use of "#" in an href value can cause problems depending on the use of the link. But simply removing the href altogether isn’t good either since it will make the code invalid. What I have found to be a much better approach is to simply use an empty javascript call. Works great, makes the code valid, and doesn’t interfere with the behavior of the link.
Jeff
MODX Staff
