QuickEdit, what am I missing?

25 Posts

Fellini 8.5 Reply #1, 20 years, 11 months ago

Finally taking a free moment to experment with the new release, and the included QuickEdit module. Looking at it’s doc: http://www.modxcms.com/quickedit.html, I opted for the "tag method" because "That’s all there is to it. The module will take care of the rest."

Got the link to show up and all, but it’s calling javascript functions, and there doesn’t seem to be any links to a .js file or any <SCRIPT> tags added to my page source at all for that matter.

So...

Was I supposed to actually add any <SCRIPT> tags to my templates manually? Or is there a whole other set of steps I’m completely missing that weren’t on that page of documentation? Or was the module supposed to add the tags and I have a config error?

Quick details about the test site: Eto 6.0 base, upgraded to the previous ModX release, upgraded to this ModX release. Still a noob trying to find my way around, otherwise.

(BTW, if it’s #1 or 2, you might want to change that "That’s all there is to it" line in the doc... wink

)

680 Posts

aNoble Reply #2, 20 years, 11 months ago

Quote from: Fellini at Oct 31, 2005, 12:45 PM

Was I supposed to actually add any <SCRIPT> tags to my templates manually? Or is there a whole other set of steps I’m completely missing that weren’t on that page of documentation? Or was the module supposed to add the tags and I have a config error?

If you are logged in then it should be adding some javascript links to your html output.

The included headers should look like this:

<!-- Start QuickEdit headers -->
<script type="text/javascript">
 var modId = '1';
 var managerPath = '/modx/manager/';
</script>
<script src="assets/modules/quick_edit/javascript/cookies.js" type="text/javascript"></script>

<script src="assets/modules/quick_edit/javascript/output.js" type="text/javascript"></script>
<script type="text/javascript" src="manager/media/script/scriptaculous/prototype.js"></script>
<script type="text/javascript" src="manager/media/script/scriptaculous/scriptaculous.js"></script>
<link type="text/css" rel="stylesheet" href="assets/modules/quick_edit/styles/output.css" />
<!-- End QuickEdit headers -->

If they’re not getting included automatically then something is wrong, might be an upgrade problem. Your are seeing the links right? Are you seeing the QuickEdit toolbar? You can check the opensourcecms.com demo to see the way it should work (username: admin, password: demo).

Adam Crownoble: obleDesign.com | [email protected] | [email protected] (Google Talk)

25 Posts

Fellini 8.5 Reply #3, 20 years, 11 months ago

Nope, none of the header code is getting added; it’s just adding the <a href="#"> for the quick edit link. I don’t see the little toolbar either. I’m logged in via the manager (which seems to work in the demo, the user login said that username/pw was invalid) since I haven’t set up a diff. login page yet.

My template is relatively barebones in the header right now since this started off in Eto:

[[phpBB_Initialize]]<!DOCTYPE html public "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3c.org/TR/1999/REC-html401-19991224/loose.dtd">
<HTML lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">
<HEAD>
<title>[(site_name)] » [*pagetitle*]</title>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
	[[GetKeywords]]
        <link rel="stylesheet" type="text/css" media="print" href="assets/site/btf_subpage.css">
        <style type="text/css">
             @import url('assets/site/btf_subpage.css');
        </style>
</HEAD>

...is there some other hook/snippet/whatever that I should have in here that I’m totally missing? Nothing leapt out at me in the docs.

("phpBBInitialize" is my own snippet that includes a bunch of php for my forum integration that needs to be at the beginning of the page, BTW)

And wow, there’s a lot of stuff in that demo site that an Eto-upgrader like me would never have noticed was available...

(Oh, I looked all over for the link to this demo too when I saw it mentioned in the forum, thanks for it!)

680 Posts

aNoble Reply #4, 20 years, 11 months ago

Oh, boy. I think I know what it is. I really should have seen that coming. Personally I always user lower-case tags, so it just slipped my mind.

Try changing your <HEAD> and </HEAD> to <head> and </head> and see if it works.

Please let me know if that fixes it. If that is the problem I’ll be sure to get it fixed by 9.1.

Adam Crownoble: obleDesign.com | [email protected] | [email protected] (Google Talk)

25 Posts

Fellini 8.5 Reply #5, 20 years, 11 months ago

Quote from: aNoble at Oct 31, 2005, 02:37 PM

Try changing your <HEAD> and </HEAD> to <head> and </head> and see if it works.

Please let me know if that fixes it. If that is the problem I’ll be sure to get it fixed by 9.1.

*ding* *ding* *ding* We have a winner! grin

Cool, that works fine. So much for my old copy of CodeSweeper... I should probably tweak that one of these days...

On to my next puzzle! Thanks!

680 Posts

aNoble Reply #6, 20 years, 11 months ago

Well at least that should be an easy fix.

Bug report logged

Adam Crownoble: obleDesign.com | [email protected] | [email protected] (Google Talk)