Little bug in RSS-format of Ditto

In rss.format.inc.php, string #40
Tag "link" must contain URL of site, but not URL of RSS-feed!

I think string #40:
$rss_placeholders[’[+rss_link+]’] = $modx->config[’site_url’]."[~".$modx->documentObject[’id’]."~]";

must be:
$rss_placeholders[’[+rss_link+]’] = $modx->config[’site_url’];

As compared to variable name, it looks appropriate ...

rss_link -> rss feed

Quote from: zi at Oct 23, 2008, 04:35 AM

As compared to variable name, it looks appropriate ...

rss_link -> rss feed

Yes, but in default RSS-template this variable (placeholder) is inserted in link tag (string #117).
As far as I know, this tag is used to show site URL where RSS is.

Probably the right way is to replace string #117 ?
from:
<link>[+rss_link+]</link>
to:
<link>[(site_url)]</link>

Quote from: Urique at Oct 23, 2008, 05:11 AM

....
Probably the right way is to replace string #117 ?
from:
<link>[+rss_link+]</link>
to:
<link>[(site_url)]</link>

This sounds good way to customize to your liking OR just create a new template as a chunk and use that instead of default.

Can’t consider it as a bug though.

Quote from: zi at Oct 23, 2008, 05:33 AM

This sounds good way to customize to your liking OR just create a new template as a chunk and use that instead of default.
Can’t consider it as a bug though.

1. I think top of people use default template of Ditto to generate RSS.

2. Maybe it is not most important, but i think it is incorrect RSS-format/specification (look http://web.resource.org/rss/1.0/spec#s5.3.2).
In default template link attribute is URL to RSS, but specification of RSS show another usage of these tag!

3. I think there is too much words about this little question, if you want users of Ditto customize default template - OK.
I created this post just to inform designers of Ditto!

Thanks 4 answer.

Alright, this makes more sense.

Thanks for the improvement proposal, and I would like to invite you to add a bug/feature report in Ditto tracker so this doesn’t get buried in forums.

regards.