Output HTML Entities

Greetings,

I’ve looked and searched and haven’t found an answer to this. Hopefully someone can point me in the right direction.

MODx is storing content like pagetitle, etc. exactly as entered, and Wayfinder (and other snippets for that matter) don’t appear to be HTML encoding the output; quotes to ", ampersand to &, etc. Content entered in a rich-text box with TinyMCE is being HTML encoded at the point of entry, so is OK.

A example of a resultant problem In Wayfinder, for instance, if a user has entered a quote in the title (can’t expect them to type &quot;) as an inch mark, it’s even breaking the title attribute of the <a> element output, as there are unbalanced and unescaped quotes within the title attribute.

Ideas how I can square this away -- manager input? Snippet output? If I’ve missed it somewhere, please forgive me; only my second MODx project.

Thanks in advance.

Maybe a solution: http://modxcms.com/forums/index.php/topic,18122.0.html

Huh, I was turning blue searching and didn’t find that post. Thanks.

That patch should do me, although as the author of the other post hinted, I’d need retrieve the charset from $modx’s config and use it in the htmlentities() charset param in order to match the site’s character set

I was kind of hoping I was missing a parameter somewhere; I really hate to patch the Wayfinder code for just my app. I’ll have to do so for other snippets such as AjaxSearch as well, for the same reason. Oh, well.

Another search: http://modxcms.com/forums/index.php/topic,13620.0.html

Could this be done for title?

Apparent Clean Solution Found

In case anyone follows me in this, I believe that I’ve found a solution right under my nose: the PHx plugin (http://wiki.modxcms.com/index.php/PHx).

The plugin allows per-field (tag) output modification via definitions in-template, including application of htmlentities(). I looked under the hood, and it’s even taking the site’s character set into account and using it in the htmlentities() call. Beautiful.

For instance, to clean up the pagetitle in the title element portion of a template, all I had to do was change:

<title>[(site_name)] | [*pagetitle*]</title>

to

<title>[(site_name)] | [*pagetitle:htmlent*]</title>

Wayfinder doesn’t support PHx directly, but it can still be done. A pre-PHx row template like:

<li[+wf.id+][+wf.classes+]><a href="[+wf.link+]" title="[+wf.title+]" [+wf.attributes+]><span>[+wf.linktext+]</span></a>[+wf.wrapper+]</li>

becomes

<li[+wf.id+][+wf.classes+]><a href="[+wf.link+]" title="[+phx:input=`[+wf.title+]`:htmlent+]" [+wf.attributes+]><span>[+phx:input=`[+wf.linktext+]`:htmlent+]</span></a>[+wf.wrapper+]</li>

I’m going to drive it around a bit on a non-production site to see if there’s a notable performance penalty (page caching should negate) or other problems, but it looks like an elegant solution to a problem that’s been bugging me quite a bit.

Thanks for sharing!! I have phx installed and will try it!