Non critical Issue with menu items when pagetitle contains a "

A client of mine has helped me discover an issue when a pagetitle contains the character [tt]"[/tt]

Example :

pagetitle is [tt]Le programme "Vivre avec le Soleil, à l’école"[/tt]

Generated menu item is :

[tt]<a école="" l="" à="" soleil,="" le="" avec="" vivre="" title="Le programme " href="/~soleil/ecole/le-programme-vivre-avec-le-soleil-a-lecole.html">Le programme</a>[/tt]

I guess the " character messes up the link’s construction.
Of course as it is, the link works, but it breaks validation.

(several things like [tt]"Vivre" is not a member of a group specified for any attribute[/tt])

I don’t think it’s an issue with the call but here it is :



Wayfinder version is version 2.0 with MODx 0.9.6.

Any possible fix other than not using pagetitle for menu items ?

Update the code to escape the quotes and special characters. Probably makes good sense to add that as a part of the base anyway.

I take it you mean use the 0.9.6 update you did for the alias auto-generation and use it in Wayfinder ?

No ... update Wayfinder’s use of the pagetitle field to escape special characters like quotes, not strip them out.

OK thanks Ryan I’ll do that and report

Excellent use of the PHP training you had earlier this year.

Sure is
Too bad I had too much business to pratice (summer will be useful, no contracts coming up)

I admit I am struggling a bit, I looked at every use of str_replace and preg_replace, htmlentities and anything which would look like a replacement array in wayfinder.inc.php but the beast is 600 lines long : so far, no luck (Any pointer ?)

And my training didn’t cover OO or regular expressions
That’s frustrating !

I can make sense of about 70% of what’s in there, but there are some thing I am totally lost with... I have never clicked with PHP and I think it will take not only a week’s training + no practice but a few weeks practicing and then another training to really get into it.

Hi David,

Perhaps in this line (in renderRow function around line 180)



:-)

Thanks

Before you hinted at this line I was looking at this



and I did suspect it had something to do with $phArray, but then the code you posted does not help me understanding which character replacement is applied (I guess it takes having a global understanding of wayfinder’s code to grasp this).

Anyway it’s a good lesson to be a beginner again, helps reminding you how other’s help and patience is key to progress !