Support/Comments for QuickManager+ 1.3--

128 Posts

Richard Reply #91, 16 years, 9 months ago

As qm is now part of the core installation would it make sense to fix the javascript errors due to the missing parent and top objects when editing a resource.

There are a couple of places that need updating in the core MODx code to check for the existance of the object:

manager/includes/header.inc.php around line 33:

        // set tree to default action.
        if (parent.tree) parent.tree.ca = "open";

	// call the updateMail function, updates mail notification in top navigation
        if (top.mainMenu) {
		if(top.mainMenu.updateMail) {
			top.mainMenu.updateMail(true);
		}
	}

and
manager/actions/mutate_content.dynamic.php around line 187:

// save tree folder state
if (parent.tree) parent.tree.saveFolderState();

634 Posts

Lammikko Reply #92, 16 years, 9 months ago

Quote from: uxello at Dec 07, 2009, 04:20 AM

As qm is now part of the core installation would it make sense to fix the javascript errors due to the missing parent and top objects when editing a resource.

There are a couple of places that need updating in the core MODx code to check for the existance of the object:

manager/includes/header.inc.php around line 33...

Would you be kind and add this to JIRA so that core developers will notice this too: http://modxcms.com/community/jira.html

Mikko Lammi, Owner at Maagit

128 Posts

Richard Reply #93, 16 years, 9 months ago

No problem. http://svn.modxcms.com/jira/browse/ADDON-87

120 Posts

moondawg69 Reply #94, 16 years, 9 months ago

Just noticed in QM front end editing bar - when in Spanish - the Create Resource Here (Spanish version) has a question mark next to it.

Loving Modx!

Web design agency in Tunbridge Wells

654 Posts

mconsidine Reply #95, 16 years, 9 months ago

I’m finding that if someone edits a document using QuickManager (latest version, Evo 1.0.2, in conjunction with ManagerManager), they log out and I log in via the back-end (i.e. the traditional manager interface), I get a message that the document is currently being editted. Even though it’s not. "Remove locks" fixes this, but that’s not a solution.

It seems like this is or is related to a similar "locking" issue noted above. Is that correct? Is there a workaround? I don’t understand why once they are logged out things wouldn’t be returned to their initial state. If I’m missing something and someone could clarify things, I’d be appreciative as at the moment this is my only front-end editting option.

MattC

634 Posts

Lammikko Reply #96, 16 years, 9 months ago

Quote from: mconsidine at Dec 14, 2009, 06:19 PM

It seems like this is or is related to a similar "locking" issue noted above. Is that correct? Is there a workaround? I don’t understand why once they are logged out things wouldn’t be returned to their initial state. If I’m missing something and someone could clarify things, I’d be appreciative as at the moment this is my only front-end editting option.

Yes, you are correct. Unfortunately there is not easy fix available. I’ll try to fix this bug in the future but right now I’m too to busy to develop QM+ until late January.

Are you by the way logging out to front-end or to the manager screen? I have mainly used logging out to the manager screen and in my tests logging out removes users document locks. Only if user doesn’t log out there will be a problem.

Mikko Lammi, Owner at Maagit

634 Posts

Lammikko Reply #97, 16 years, 9 months ago

Quote from: Moondawgy at Dec 14, 2009, 08:28 AM

Just noticed in QM front end editing bar - when in Spanish - the Create Resource Here (Spanish version) has a question mark next to it.

QM+ takes all language strings from "manager/includes/lang/". I’ll have to check this out later when I’m on a computer with access to MODx installation.

Mikko Lammi, Owner at Maagit

634 Posts

Lammikko Reply #98, 16 years, 9 months ago

Quote from: Moondawgy at Dec 14, 2009, 08:28 AM

Just noticed in QM front end editing bar - when in Spanish - the Create Resource Here (Spanish version) has a question mark next to it.

I checked this through SVN and found out that there is two spanish language files. You are propably using spanish language file that is saved with iso-8859-1 character encoding ("manager/includes/lang/spanish.inc.php").

Does you front-end template use UTF-8 encoding? I’m guessing it does. That’s why "Crear documento aquí" becomes "Crear documento aqu?".

Mikko Lammi, Owner at Maagit

654 Posts

mconsidine Reply #99, 16 years, 9 months ago

Hi,
Thanks for your reply. I’m logging out to the front-end. The setup is to have a restricted manager login via ManagerLogin snippet on the front-end. They are directed to a particular document that they can edit via QM, with ManagerManager controlling what they see in terms of document fields.

I’m guessing they are saving, but then not going back up to the bar to logout, but am not sure yet.

Any help would be appreciated - this seems to be my only editing option at the moment. And if there’s another way I should be configured advice on that would be great too.
Matt

247 Posts

claytonk Reply #100, 16 years, 9 months ago

I notice the "delete" button is commented out in the source as "not implemented yet". Having this button would be really useful for my current project. What would it take to implement this? Is it something a loser could do or does it require actual intelligence and PHP proficiency?