Support/Comments for Error 404 Logger

Nope... Actually, I hadn’t much time for it..

http://modxcms-jp.com/bb/viewtopic.php?f=34&t=233

for evo.

http://modxcms-jp.com/bb/viewtopic.php?f=34&t=233

for evo.

thanks yama!

yama, your site returns a mysql error.

ok, please wait a little

First of all: Great module!
One of the first things I install on every new site

A minor bug I found last times:
In the e404logger.class.inc.php you’re using php short tags but not every hosting provider supports this. If you call the module, you’ll see the code of the class in plain text and you’ll get an error (Error404Logger class not found). Perhaps for any further relases: Use "<?php" instead of "<?"...

Cheers,
Chris

hello Chris.

http://modxcms-jp.com/bb/viewtopic.php?f=34&t=233
It is repared.

Attention! There is vilnerabilities in this module. SQL injection is possible.
Patch file \assets\modules\error404logger\e404logger.class.inc.php



And remember to keep the plugin of this module first for ’PageNotFound’ event sequence.

Quote from: Andrey at Feb 18, 2011, 12:14 AM

Attention! There is vilnerabilities in this module. SQL injection is possible.
Patch file \assets\modules\error404logger\e404logger.class.inc.php

	// add 404 query
	function insert($ip, $url, $referer) {
	global $modx;
	  $modx->dbQuery("INSERT INTO ".$this->tableNameModx." (url, ip, host, referer, createdon) VALUES ('".$modx->db->escape($url)."','".$modx->db->escape($ip)."', '".gethostbyaddr($ip)."', '".$modx->db->escape($referer)."', '".date('Y-m-d H:i:s',time())."')"); 
		return $modx->db->getInsertId();
	}

And remember to keep the plugin of this module first for ’PageNotFound’ event sequence.

THANKS!

Thanks.

http://code.google.com/p/modx-evo-extra-ja/downloads/detail?name=Error 404 Logger006.zip
updated