problem with newsindex

Hello,

I’m using the newsindex snippet below. However, it seems that the pagination part doesn’t produce acurate results. unfortunately, it is beyond my skill set to fix the snippet. it would be nice, if there is only one page that no page number would be added. in some instances, the snippet shows me 4 pages although there is no entry on the fourth page.

I would appreciate if somebody could do some debugging or is there an alternative to this snippet.

thank you in advance for your help.

anybody???

Hi mmjaeger,

Out of curiosity, where did the snippet come from, and what is it supposed to do? I’ll take a look at it very soon.

Thanks!

Hmmm...a paginator TV...

From looking and trying the snippet, it seems like a very simple/early copy of NewsListing. What were you hoping it would do that Newslisting does not?

I agree with Sottwell, here. What we need is a good paginating and autoindex-building snippet.

Sorry, I should have put the whole snippet here - the listing of the news works - what’s causing troubles is the paginator at the bottom - the results produces are just not accurate - it e.g. show that there are four pages when in fact there are only three. Moreover, the page indication should be hidden if there is only one page.

/*****************************************************************
* NewsIndex
* Created by: Wayne Chu
* wayne at freethought dot ca
* Sep 2, 2004
*
* Description:
* Displays a paginated list of items in
* the specified folder.
*
* Usage: [[NewsIndex?newsid={id}&desc={true|false}&sep={string}&pub=1]]
* Variables: newsid - the ID of the folder to retrieve items from
* desc - Optional boolean indicating if the page
* description should be displayed
* sep - Optional variable defining the separating
* string between the date and the title
* pub - Optional variable defining whether to publish
* unpublished items (1 = published, 0 = unpublished)
*
****************************************************************/

$itemsPerPage = 5;
$itemCss = "newslistitem";
$itemCssDate = "newslistdate";
$itemCssTitle = "newslisttitle";
$itemCssPaging = "newslistpaging";
$itemCssDescription = "newslistdesc";
$separator = "
";
//$dateFormat = "%F %j, %Y";
setlocale (LC_TIME,"de_DE");
$dateFormat = "%A, %e. %B %Y";


if (isset($sep))
$separator = $sep;

// News Folder
$id = isset($newsid) ? $newsid : $etomite->documentIdentifier;
// Current Page
$currPage = isset($_GET[’page’]) ? $_GET[’page’] : 1;

// News Folder
$folder = isset($newsid) ? $newsid : $etomite->documentIdentifier;
// Current Page
$currPage = isset($_GET[’page’]) ? $_GET[’page’] : 1;

$items = $etomite->getAllChildren($folder, ’createdon’, ’DESC’, $fields=’id, pagetitle, description, content, createdon, createdby’);
$totalItems = count($items);
if ($totalItems < 1)
return;

$totalPages = (int)($totalItems / $itemsPerPage);
if ($totalItems % $currPage > 0)
$totalPages++;

if ($currPage < 1 || $currPage > $totalPages)
$currPage = 1;

$firstItem = ($currPage * $itemsPerPage) - $itemsPerPage;
$lastItem = ($currPage * $itemsPerPage);
if ($lastItem > $totalItems)
$lastItem = $totalItems;
$output = "";

// Display news items
for ($i=$firstItem; $i<$lastItem; $i++) {
$output .= "<div class=’" . $itemCss . "’>";
$output .= "<span class=’" . $itemCssDate . "’>" . strftime($dateFormat, $items[$i][’createdon’]) . "</span>";
$output .= "<span class=’" . $itemCssTitle . "’>";
$output .= "<a href=’[~" . $items[$i][’id’] . "~]’>" . $items[$i][’pagetitle’] . "</a>";
$output .= "</span>";
$output .= "</div>";
if (isset($desc) && $desc == true)
$output .= "<div class=’" . $itemCssDescription . "’>" . $items[$i][’description’] . "</div>";
$output .= $separator;
}

// Display Pagination

$paginationGroup = (int)(($currPage-1) / 10);
$firstDisplayPage = ($paginationGroup * 10) + 1;
$lastDisplayPage = ($paginationGroup * 10) + 10;
if ($lastDisplayPage > $totalPages)
$lastDisplayPage = $totalPages;

$output .= "<div class=’" . $itemCssPaging . "’>[ ";

if ($totalItems < $itemsPerPage) {
$output .= " <strong>1</strong> ";
} else {
if ($firstDisplayPage > 1)
$output .= "&nbsp;<a href=’[~" . $etomite->documentIdentifier . "~]&page=" . ($firstDisplayPage-1) . "’>...</a>&nbsp;";

for ($j=$firstDisplayPage; $j<=$lastDisplayPage; $j++) {
if ($j == $currPage)
$output .= "&nbsp;<strong>" . $j . "</strong>&nbsp;";
else
$output .= "&nbsp;<a href=’[~" . $etomite->documentIdentifier . "~]&page=" . $j . "’>" . $j . "</a>&nbsp;";
}

if ($lastDisplayPage < $totalPages)
$output .= "&nbsp;<a href=’[~" . $etomite->documentIdentifier . "~]&page=" . $j . "’>...</a>&nbsp;";
}

$output .=" ]</div>";

return $output;