[Module] Front End Editing (split from Adding an Edit Button to every page)

As far as the font color, I’ll add some css to force it to black on hover, that should take care of it.

Adding a border does affect the layout in that it will increase the size of the block element by the width of the border. Outlines, on the otherhand will not affect the layout but they are not supported by IE.

As far as the caching goes, I am aware that this is a problem and I’m working on a solution now. I’m not especially familiar with the way that caching works in MODx (I’ve always considered it a necessary evil ) so I’ve been trying to give myself a crash course. But if someone who knows the caching system well would like to give me some advice I’d be happy to have it.

So far, I’m thinking of going with something like using [*tvname:editable*] and replacing it with [*tvname*]<!-- EDITLINK:tvname --> and letting it be cached and then replace <!-- EDITLINK:tvname --> with <a href="...">edit tvname</a> just before rendering. The other option would be using [!tvname:editable!] and replacing it with [!tvname!]<a href="...">edit tvname</a> in one step. What I don’t like about this is that it doesn’t let you cache any of the editable TVs.

Does this sound like a good idea? If anyone has a better idea I’d love to hear it.

I tried it in IE 6.0 since that is what the user will be running.

Seems to be working fine for me in IE and Firefox. Does FCKeditor work for you through the manager? I’d try emptying out your cache, cookies, etc and see if that’s causing some problems. Other than that I can’t think of what the problem could be.

Does FCKeditor work for you through the manager?

No, when running you modded version but yes in the normal TP 3.1 version.

That is strange. I can’t think of anything that would cause that. None of the code in the hack should affect the manager side of things at all. You might want to just play around with it and see if maybe it’s just coincidence or maybe copy the individual files from the hack one by one and see which file is causing the problem. If it’s any file it would probably be document.parser.class.inc.php.

Sorry for the hassle, I wish there was more I could do to help you fix this but since I can’t reproduce the problem there’s not much more I can do. If this is a public website you could email me a username password ([email protected]) with limited permissions, you can just give me permission to edit one page if you like and I can see if I can figure it out (if you don’t want to give me a login I understand completely). I’d be curious to know if the problem is the same from any computer accessing your site or just something with your computer.

Quote from: aNoble at Jul 28, 2005, 08:56 PM

Is the content that is getting highlighted white by chance? The light green color of the highlighter could cause problems with light colored fonts. We could either change the color of the font also when hovered over or we could ditch the background color and just change the border... I think someone will probably end up make some graphical changes to the frontend editing links.

Man do I have some really potentiall cool ideas here... Just give me classes on the links, and a DIV for the surrounding area and I’m one happy camper.

Okay, here’s an update. I think I have the caching issue figured out. I used the comments replaced by links method I mentioned earlier. If the user is logged in he will see the links, if not the comments will be removed and it should look normal. Again, if anyone has a better idea I’d be happy to hear it. I also fixed the highlighting white text problem by forcing black text on hover.

As far as styling, the class is tv_edit and I haven’t done anything to force a containing div or anything like that. That is really up to the template creators but I’d imagine it could give some undesireable results. Someone already mentioned some strange things happening just because of the 1px border. It would be great if you could whip up some cool styling.

The atached files are for testing only. I haven’t had any time to really test the changes I made tonight but I thought you guys would want to take a look and I didn’t want to keep you waiting ’till tomorrow, so here it is.

[edit]
I forgot to mention that I have changed the format for flagging content as editable. Instead of using [#tvname#] use [*tvname:editable*] or [!tvname:editable!]. The links themselves will not be cached regardless of whether you use [**] or [!!] This way you have the flexibility of still choosing whether or not you want the TV cached and it’s more self-explanatory than [##].
[/edit]

Man just made a new installation on http://modx.kinghosting.nl/ just your files switched cashing off an d refreshed the site even deleted the cash files, but still its not working do i miss somthing is there more to be set or done?

I pm you the login for manager and ftp so if you like you could take a look what is hapening here.

Sorry Dimmy, I forgot to mention that I changed the format for flagging content as editable (I was tired). See the edit to my post above for details.

It creates a funny result look at http://modx.kinghosting.nl all I have changed is the longtitle tag but the same hapens with the content tag.

(I pm’d you my login so you could test it yourself if you like)