We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
MODX Community Forums Archive

Manage Files > Image Preview doesn't work?

    • 32058
    • 3 Posts
    Weasol Reply #1, 15 years, 3 months ago


    At first I thought it was an upgrade issue, but I’ve tried a clean install. Clicking on the magnifying glass icon does nothing. Is this a known issue and I just don’t know what the correct search terms are to find the fix?

      • 7231
      • 4,205 Posts
      dev_cw Reply #2, 15 years, 3 months ago
      Interesting, I never used that feature and it works for files (html, php, txt) but it does not open the images. I tested on 0963 with FF3.
        [font=Verdana]Shane Sponagle | [wiki] Snippet Call Anatomy | MODx Developer Blog | [nettuts] Working With a Content Management Framework: MODx
        Something is happening here, but you don't know what it is.
        Do you, Mr. Jones? - [bob dylan]
        • 4310
        • 2,310 Posts
        bunk58 Reply #3, 15 years, 3 months ago
        Seems to work in 0.9.6.1 & 0.9.6.2 but not 0.9.6.3, tested with .jpg, .gif & .png

        Doing a quick view sorce of the frame shows this in 0.9.6.2 :
        onclick="viewfile('../assets/arrow_down.gif')

        Whereas in 0.9.6.3 it’s this :
        onclick="viewfile('..%2Fassets%2Farrow_down.gif')

        Is it a bug ?
          • 4310
          • 2,310 Posts
          bunk58 Reply #4, 15 years, 3 months ago
          I’ve had a quick look at manager/actions/files.dynamic.php
          At line 440 changing :
          onclick="viewfile(\''.urlencode($webstart_path.substr($newpath, $len, strlen($newpath))).'\');

          to
          onclick="viewfile(\''.$webstart_path.substr($newpath, $len, strlen($newpath)).'\');

          seems to fix the problem, looks as if  urlencode was added for 0.9.6.3

          This is from 0.9.6.2 :
          onclick=\"viewfile('$webstart_path".substr($newpath, $len, strlen($newpath))."');


          I’ve added this in the JIRA.
            • 32058
            • 3 Posts
            Weasol Reply #5, 15 years, 3 months ago
            Thanks guys for taking the time to answer and investigate.

            Much appreciated
              • 31955
              • 84 Posts
              warenhaus Reply #6, 15 years, 3 months ago
              I cannot test it now (as I’m not at home), but that seems to solve one of my problems.

              Can someone here also have a look at the other one? it’s possibly related:
              http://modxcms.com/forums/index.php/topic,31850.0.html

              [edit: was link to wrong topic]
                • 31955
                • 84 Posts
                warenhaus Reply #7, 15 years, 2 months ago
                tested it now, and it solved one of my issues indeed.
                thanks a lot!

                still no preview in the MCPUK resource browser though. but that might be unrelated.
                  • 31955
                  • 84 Posts
                  warenhaus Reply #8, 15 years, 2 months ago
                  not sure if that’s related, but I noticed another issue now:

                  Previews of .php-files & images works fine now in the Resources->filemanager, BUT the download-address of documents is wrong:

                  I uploaded a .doc-file to assets/docs, and the address linked to by the floppy-icon (save as) is:
                  http://www.MYDOMAIN.COM/manager/..%2Fassets%2Fdocs%2FMYFILE.doc
                  instead of
                  http://www.MYDOMAIN.COM/assets/docs/MYFILE.doc

                  i guess it’s the same issue?
                  • onesmarthost Reply #9, 15 years, 2 months ago
                    What path do you have set in

                    Tools - Configuration - Interface & Features

                    Resource URL:
                    Resource path:

                    Also in Tools - Configuration - File Manager

                    File Manager Path:

                    For example mine are:

                    Resource URL: assets/
                    Resource Path: assets/
                    File Manager Path: = D:/Domains/onesmarthost.co.uk/wwwroot

                    It sounds to me like your paths are setup wrong and is adding in /manager/ assets

                      http://www.onesmarthost.co.uk
                      UK MODX Hosting with love.
                      • 31955
                      • 84 Posts
                      warenhaus Reply #10, 15 years, 2 months ago
                      Quote from: Onesmarthost at Feb 12, 2009, 12:27 AM

                      For example mine are:

                      Resource URL: assets/
                      Resource Path: assets/
                      File Manager Path: = D:/Domains/onesmarthost.co.uk/wwwroot

                      interesting. Your settings seem not to be in line with these recommendations here: http://modxcms.com/forums/index.php/topic,31771.0.html

                      I changed my settings along yours to:

                      Resource URL: assets/
                      Resource Path: assets/
                      File Manager Path: /srv/www/vhosts/MYDOMAIN/htdocs/


                      but there is no change in this doc-linking behaviour compared to my previous settings:
                      Resource URL: /srv/www/vhosts/MYDOMAIN/htdocs/assets/
                      Resource Path: /assets/
                      File Manager Path: /srv/www/vhosts/MYDOMAIN/htdocs/