Jot: Xtendable version

50 Posts

OlivierF Reply #21, 16 years, 10 months ago

Hi,

in another post http://modxcms.com/forums/index.php/topic,24445.0.html I read the question for help to take over jot 1.x support.

How about you take over and build some more things into it? You already work on an extendable version and also made the great JoCo module...

I would love:
- reply to comments
- email to be set by TV
- integration of your great JoCo tool

Thanks for your great work so far!

Happy to have left Back Pain | Sciatica behind.

☆ A M B ☆
455 Posts

AHHP Reply #22, 16 years, 10 months ago

Hello Oliver,
I like to extend Jot snippet and update JoCo but i’m a little busy to do that.
Losendae and i are working on comment tool (backend/frontend) for Revo and it may help us to use same logic for Evo version too.

About features you told, Jot structure does not allow to set Reply feature unless more and more processing and about two other items please tell more, what do you mean about set email by TV or what is in your mind in JoCo and Jot?

Thanks
AHHP

God loves me. 【ツ】

MODX.ir (Persian Support)

Boplo.ir/modx/ (Persian)

50 Posts

OlivierF Reply #23, 16 years, 10 months ago

Hi AHHP

Tnx for reply, sounds like lots of people working on Revo then. Oh well, if Revo replaces Evo, fine by me, but for now I still think that some more commenting possibilities are needed.

You said that Jot structure does not allow to set Reply feature unless more and more processing and about two other items, do you mean to say it is impossible or just requires more logic in the jot code? If it is impossible it is impossible, but on wordpress (burned my fingers yesterday all day on that again and once again understand why I am a modx fan - big time!) it can be done. It looks good, it supports interaction on our blog pages, cause you can reply to a comment, to which the original commenter then can reply again.

If we mean to get interaction with people, I would vote for replies to individual comments, unless there are good reasons not to do that, maybe me just being lazy and wanting to see a whole thread together...

Re email by TV, I mean this: on a per document basis I specify in the TV who will recieve an email if there was a comment, that would be the document’s writer’s email, hope that makes it clear.

You also asked what I have in mind with Joco and Jot, maybe just one small thing, make it just one package.

Thanks for your work so far, much appreciated!

Oliver

Happy to have left Back Pain | Sciatica behind.

☆ A M B ☆
455 Posts

AHHP Reply #24, 16 years, 10 months ago

About reply, you know that impossible is impossible. Jot does not allow us to add it, if we want, we should change Jot logic (add a DB column, some process while getting comments, some process while printing comments and etc).
I think Jot is a little heavy and add some extra logic (including this -Events- package) may make it heavier and i think it’s better to create a new one, with more features and more performance. I really want to work on a new addon but i am currently very busy but if our Revo instance starts, we can think about Evo version too or i am interesting to start a new one in feature too.

About email, do you mean set emails for notification?
Please see some related samples that i’ve created and put in this package. It’s possible with this version of Jot.

And about Jot-JoCo. The problem is JoCo has some bugs and i have no time to check that.
I have really problem with Javascript and CSS in IE!!
I started new JoCo with Mootools in summer but i had IE problems again and it wasn’t done.
Please tell me more about your ideas.

Thanks
AHHP

God loves me. 【ツ】

MODX.ir (Persian Support)

Boplo.ir/modx/ (Persian)

251 Posts

cms Reply #25, 16 years, 8 months ago

Hi There,

This is probably a really obvious question but is this included as part of Jot or is it a separate download? If it is a download, could someone give me a link?

Cheers

Sorry, finally saw the mini-attachment icon, cheers

☆ A M B ☆
1,031 Posts

Jako Reply #26, 16 years ago

Very nice thing grin

Just two suggestions.

1. It would be great to have onBeforeSaveComment, too. To unset fields before saving and add/change fields before saving etc.

This could be done in jot.db.class.inc.php ’Save’, lines 128 ff

	function Save(){
		global $modx;
		
		foreach($this->fields as $n=>$v) { $this->fields[$n] = $modx->db->escape($v);}
			
		if($this->isNew){

			$this->fields['id'] = $modx->db->insert($this->fields,$this->tbl["content"]);
			$object = & $this;
			onBeforeSaveComment($this->fields['id'], $object);

			foreach($this->cfields as $n=>$v) { 
				$insert = array(
					'id' => $this->fields['id'],
					'label' => $n,
					'content' => $modx->db->escape($v)
				);
				$modx->db->insert($insert,$this->tbl["fields"]);
			}
			
			$this->isNew = false;
		} else {
			$id=$this->fields['id'];
			$object = & $this;
			onBeforeSaveComment($this->fields['id'], $object);
			$modx->db->update($this->fields, $this->tbl["content"], "id=$id");
			
			foreach($this->cfields as $n=>$v) { 
				$update = array(
					'id' => $id,
					'label' => $n,
					'content' => $modx->db->escape($v)
				);
				if (!$modx->db->update($update, $this->tbl["fields"], "id=$id and label='".$update["label"]."'")) $modx->db->insert($update,$this->tbl["fields"]);
			}
		}
		
		// onSaveComment
		$object = & $this;
		onSaveComment($this->fields['id'], $object);
	}

2. It would be better to use not a fixed jot.events.php - maybe the filename could be set by parameter. Or the functions could be capsulated in jot.events.php by "if (!function_exists(’onSaveComment’))". So they could be set in a snippet before the Jot call like in eForm.

385 Posts

Temus Reply #27, 14 years, 3 months ago

Where can I download files? Attachment is missing.