[Plugin] HideEditor

I’ll check and confirm this, didn’t notice it yet... thanks Zi...

Any idea what’s the cause of this ?

David, did you test it in IE?

Here is a screenshot of the error:
MODx RC2: rev1942

I just got a report from my client this morning about this, didn’t have time to confirm it yet... if this is RC2 then it’s bad news... I thought it would fix it from RC1...

And I have to solve it (or convert them to FF, who knows...)

Anyone has an idea for a starting point ?

Timon’s code is a good way to implement this without hacking the core code...probably just needs some reworking by introducing some Prototype magic to it. However, the question I have is this: Should we just go ahead and add the ’nocontent’ variable into the core for 0.9.5? This would make the most sense since it would mean less work by the browser...after all, why make the browser do the work when you can have just a simple variable on the server end that simply keeps the area from being sent to the browser. What does everyone think?

Jeff

Another note...how about just having a config option that would allow for both a global and user-level override for this? Certainly would beat having to implement this as a plugin. Have to admit, this is one little feature that I think has some merit.

Why not just a simple accordian behavior for all the sections? Shouldn’t be difficult; the javascript libraries are already being used for other stuff.

Quote from: Bravado at Nov 12, 2006, 01:05 PM

Should we just go ahead and add the ’nocontent’ variable into the core for 0.9.5? This would make the most sense since it would mean less work by the browser...after all, why make the browser do the work when you can have just a simple variable on the server end that simply keeps the area from being sent to the browser. What does everyone think?

I for one think this should be part of the core, but I have advocated this for a long time

Quote from: Bravado at Nov 12, 2006, 01:07 PM

Another note...how about just having a config option that would allow for both a global and user-level override for this? Certainly would beat having to implement this as a plugin. Have to admit, this is one little feature that I think has some merit.

A config option is a bit to global I think. The neatest way would be to check if the template contains the [*content*] tag and simply skip the whole editor initialization server side if it doesn’t. Seems to me that if you’re not using [*content*] you most likely don’t have it in your template either, at least that’s how I would set up my site. And besides it feels like a logical behaviour, no content tag, no editor, no confusion...

Disagree, I can think of a number of times when you might use something other than a direct [*content*] / [*#content*] tag in the template (or indeed, may have a blank document template). However, you are correct that this is ideally a per-template thing. After all, the Template Variable inputs are displayed (or not) based on the template’s Assigned Template Variables. And in the future, content is pretty much just a TV.

So, I say ’nocontent’ should be added to the Template. Doing it per-document is too granular, doing it site-wide is too global. Template-level is logical.

Interesting idea! I like it! Making it a template-level option does make the most sense.

As far as the accordian idea...I’m for that too and there are likely going to be areas of improvement all over the manager for that. We’ll likely get some of that covered with the 0.9.7 release.