Add isset check to protect.inc.php

jamilsamara Reply #1, 18 years, 4 months ago

May I propose that line 7 of the protect.inc.php file read

if (isset($_SERVER['QUERY_STRING']) && strpos(urldecode($_SERVER['QUERY_STRING']), chr(0)) !== false)

rather than

if (strpos(urldecode($_SERVER['QUERY_STRING']), chr(0)) !== false)

?

opengeek Reply #2, 18 years, 4 months ago

This was already done some time ago, and is in trunk in subversion that way. What version of MODx are you running?

jamilsamara Reply #3, 18 years, 4 months ago

I’m running 0.9.6.1p2, and it doesn’t appear to have it. I just redownloaded the zip file at http://modxcms.com/downloads.html to confirm this also.