Patches from non-core developers, anyone?

Greetings,

I’ve just fixed a minor bug in manager/tree.php (the sorter floating panel wasn’t retracting after clicking "Go!").

How are outsider patches being handled?

Thanks!
Eric Lloyd

In short:

For any improvements to the core: Either detail the change here or attach a file with the changes. Be sure to state which version of MODx you patched (rev number from Reports: System Info). Someone who is from the core team can then confirm it works and check it into the SVN.

However, bugfixes have an extra wrinkle:

Visit http://modxcms.com/bugs/ and see if the bug is already reported, and if it has already been fixed.
If it hasn’t been reported, report it; if it hasn’t already been fixed, post either the bugfix or a link to a bugfix here in the forum.

Also, if you submit the changes in a SVN diff format, it’s much easier for the devs to see what’s going on and incorporate your changes. Thanks!

*sigh* I just looked it up and found out that it’s been fixed in the latest trunk (FS#723). It was reported to be broken on Safari, but I observed it in IE7 as well.

However, the following is a bit of a cleanup I did on the showSorter() function as I was preparing to tilt at this particular windmill:

Index: C:/Projects/modx/manager/frames/tree.php<br />===================================================================<br />--- C:/Projects/modx/manager/frames/tree.php	(revision 2258)<br />+++ C:/Projects/modx/manager/frames/tree.php	(working copy)<br />@@ -306,15 +306,9 @@<br />         }<br />     }<br /> <br />-    currSorterState="none";<br />-    function showSorter() {<br />-        if(currSorterState=="none") {<br />-            currSorterState="block";<br />-            document.getElementById(’floater’).style.display=currSorterState;<br />-        } else {<br />-            currSorterState="none";<br />-            document.getElementById(’floater’).style.display=currSorterState;<br />-        }<br />+    function showSorter() {<br />+    	var floater = document.getElementById(’floater’);<br />+    	floater.style.display = (floater.style.display == "block")? "none": "block";<br />     }<br /> <br />     function treeAction(id, name) {

This just gets rid of a bit of non-authoritative (or shadow) state and lets the DOM tell us what it knows.