We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
MODX Community Forums Archive

Meta Tage error

    • 14779
    • 256 Posts
    joshlfisher Reply #1, 18 years, 1 month ago
    I set up a ’Refresh’ meta tag for my site, but modx renders it as <meta http_equiv..... instead of <meta http-equiv.... has anyone else noticed this as a problem with modx? posted a fix?
      PM me to find out how you can get a FREE ipad 2!
      • 263
      • 52 Posts
      abbeyroad Reply #2, 18 years, 1 month ago
      Well spotted, Josh!
      This should be fixed in next release (coming soon). See bug report: http://modxcms.com/bugs/task/305
      If you are the impatient sort like me, the fix is quite straight-forward.

      In the file /manager/includes/document.parser.class.inc.php, find line 566:
      $tagstyle = $col['http_equiv'] ? 'http_equiv':'name';
      and modify it to:
      $tagstyle = $col['http_equiv'] ? 'http-equiv':'name';

      And that’s it!

      Cheers
        • 14779
        • 256 Posts
        joshlfisher Reply #3, 18 years, 1 month ago
        Thanks!
          PM me to find out how you can get a FREE ipad 2!
        • Ryan Thrash Reply #4, 18 years, 1 month ago
          Fixed and committed for the next release indeed.
            Ryan Thrash, MODX Co-Founder
            Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
            • 19726
            • 239 Posts
            Mitch Reply #5, 18 years, 1 month ago
            I almost forgot about it. I noticed a small error with the Robots metatag also yesterday. It inserts "robot" instead of "robots". Note the ’s’ at the end. This is on 0.9.1 and this is the metatag that is generated: <meta name="robot" content="noindex" />
            • Ryan Thrash Reply #6, 18 years, 1 month ago
              Mitch, where is that in the source?
                Ryan Thrash, MODX Co-Founder
                Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                • 19726
                • 239 Posts
                Mitch Reply #7, 18 years, 1 month ago
                I thought you would know since you fixed the other metatag thingy grin

                But I had a look and I found the place and fixed/tested a fix.
                Look in manager\actions\dynamic\manage_metatags.dynamic.action.php for the line:
                <option value="Robot;0">Robot</option>
                and replace it by:
                <option value="Robots;0">Robots</option>

                So it’s just adding the ’s’ at the end.