ManagerManager errors when PHP version less than 5.2.3

15 Posts

gerardL Reply #1, 16 years, 5 months ago

Hi All

First off, thanks for the latest release... gives me something to do on a wet Easter weekend wink

Unfortunately, I am getting errors from ManagerManager while editing resources in the manager:

Warning: htmlentities() expects at most 3 parameters, 4 given in E:\xampp\htdocs\modx-1.0.3-clean\assets\plugins\managermanager\functions\utilities.inc.php  on line 80

The code in question uses the double_encode parameter in a call to htmlentities... this parameter was introduced in php version 5.2.3, so it fails on earlier versions.
(I have tried it on PHP 5.2.0 and 4.4.4)

Quick fix:
Edit the file: /assets/plugins/managermanager/functions/utilities.php
Find this line (approx line 80):

return htmlentities($str, ENT_QUOTES, $modx->config['modx_charset'], false);

And replace it with:

return htmlentities($str, ENT_QUOTES, $modx->config['modx_charset']);

Seems this code was introduced in response to this issue:
http://svn.modxcms.com/jira/browse/ADDON-115

Cheers

Gerard

MODX Staff
10,725 Posts

opengeek Reply #2, 16 years, 5 months ago

Thanks for reporting; is definitely a bug that needs to be resolved.

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

15 Posts

gerardL Reply #3, 16 years, 5 months ago

I have added it to Jira in the MgrMgr section:

http://svn.modxcms.com/jira/browse/ADDON-140

Gerard

79 Posts

david55 Reply #4, 16 years, 4 months ago

I don’t (knowingly?) use ManagerManager (unless MODx 1.0.2 comes configured to use it for whatever purpose by default, and it "does stuff" behind the scenes without my knowledge?), so is this something that I would need to worry about?

I have a site that I have been developing under 1.0.2 but would like to upgrade to 1.0.3 when I make it go live. However, my server has an older version of PHP (and I’m not at all keen to upgrade PHP outwith the standard OS upgrade environment), so I’ll stick for now, if it turns out that this would prevent MODx from working?

Please don't PM me unless it's absolutely essential: if a technical question is worth asking, it's worth asking in public, so that others can share their experience, and so that all can learn from the answers.

15 Posts

gerardL Reply #5, 16 years, 4 months ago

Because ManagerManager is a plugin, if it is installed, it will run (unless it has been disabled)

If you go to Elements > Manage Elements > Plugins, you will be able to see if it is installed.
If it is in the list, but greyed out, it has been disabled.

Assuming it is installed and active, you could try disabling it and see if you notice a difference in the manager.

If it turns out that you miss its features (eg: image TV previews), then the fix outlined above is easy enough to implement.

Cheers

Gerard

79 Posts

david55 Reply #6, 16 years, 4 months ago

Thanks. I do use image TVs, so if the functionality that makes the chosen image appear in the article editing page (where the TV value is selected) is provided by ManagerManager, then I guess it may be an issue for me. I’ll hold off from upgrading to 1.0.3 for the time being: hopefully 1.0.4 will be along with a fix for this issue reasonably soon

Please don't PM me unless it's absolutely essential: if a technical question is worth asking, it's worth asking in public, so that others can share their experience, and so that all can learn from the answers.