MODx Evolution 1.0-rc3 discussion

195 Posts

jusicgn Reply #51, 17 years, 2 months ago

Ah - I see.
Thanks anyway

greetz

JUSI

242 Posts

stefan Reply #52, 17 years, 2 months ago

hello

using full cache-capabilities( e.g for Wayfinder) and webusers/webdocumentgroups at the same time is not possible.

- home(1) default
- only for customer(2) - docgroup(1)
- page
- page
- only for supplier(3) - docgroup(2)
- page
- page

1. A not logged in user create the "home" - cache-file, the nodes for 2 and 3 are not visible in the navigation.
2. Now a supplier log in, but the "only for supplier" node is still invisible btw. not shown by the cached wayfinder/cache-file.
3. clear cache and supplier refresh, the node is appear and the cache-file is written to the cache.
4. supplier log out and the node "only for supplier" is still visible for all users.
5. Now a customer log in and the node "only for customer" is not visible, the user see the "only for supplier" node instead.

The reason is the nameing of the cache-file "docid_1.pageCache.php". There is no discriminability concerning the user-rights.

A solution could be to create a "cache_id" which include the documentgroups on which the user have access eg. "docid_[docid]_[dgid].pageCache.php

Example:

1. All no logged in user read and write the default cache-file "docid_1.pageCache.php"
2. A user with rights for viewing docgroup 1 read and write the cache-file "docid_1_1.pageCache.php"
3. A user with rights for viewing docgroup 2 read and write the file "docid_1_2.pageCache.php"
4. A user with rights for viewing both, docgrp 1 and docgrp 2 read and write "docid_1_1_2.pageCache.php"

if iam right, the implementation is easy(at least as a quick hack)

to check it out... and please, do it, change the document.parser by this way

1. create a new function

function getCacheId()
{
    if( $this->isFrontend()
        && isset( $_SESSION['webDocgroups'] )
        && isset( $_SESSION['webValidated'] ) )
    {
        sort( $_SESSION['webDocgroups'], SORT_NUMERIC );
        return '_' . implode('_', $_SESSION['webDocgroups'] );
        
        //$cache_id = '_' . implode('_', $_SESSION['webDocgroups'] );
        //$this->cache_id = $cache_id
        //return null;
    }
    return null;
}

change the checkCache function to get the file

function checkCache($id) {
        // cache_id
        // $this->cache_id;
        $cache_id = $id . $this->getCacheId();
        // new filename
        $cacheFile= "assets/cache/docid_" . $cache_id . ".pageCache.php";
        // $cacheFile= "assets/cache/docid_" . $id . ".pageCache.php";

change postProcess to write the file

$cache_id = $this->documentIdentifier . $this->getCacheId();

//if ($fp= @ fopen($basepath . "/docid_" . $this->documentIdentifier . ".pageCache.php", "w")) {
// $this->cache_id
if ($fp= @ fopen($basepath . "/docid_" . $cache_id . ".pageCache.php", "w")) {

Three small changes could be a huge improvement. The behavior of the cache is not disturbed by this changes

ciao, Stefan

242 Posts

stefan Reply #53, 17 years, 2 months ago

Another thing

to replace the annoying alert-help with mootools tooltip its necessary to add a class and a title to the help images..
without hacking the core-file you can use this plugin on "OnDocFormRender"

$e = &$modx->Event;
switch( $e->name )
{
    case 'OnDocFormRender':
    echo <<<EOF
        <script type="text/javascript">
        if( !window.ie6 ) { // ie will crash.. no idea why
            $$('img[src=media/style/MODxCarbon/images/icons/b02_trans.gif]').each(function(help_img) {
                    help_img.removeProperty('onclick');
                    help_img.removeProperty('onmouseover');
                    help_img.removeProperty('onmouseout');
                    help_img.setProperty('title', help_img.getProperty('alt') );
                    help_img.setProperty('class', 'tooltip' ); 
            });
            new Tips($$('.tooltip'),{className:'custom'} );
        }
        </script> 
EOF;
        break;
    default:
        return;
        break;
}

ciao, stefan

58 Posts

iRolf Reply #54, 17 years, 2 months ago

Quote from: rthrash at Jul 26, 2009, 04:09 PM

Grrr. That shouldn’t be happening, and is a new problem. If you’re committing to SVN, PLEASE make sure you have line endings set to unix line endings in your editors and do not put any whitespace or lines after closing ?>.

iRolf, could you submit a bug to JIRA with the offending files, please.

I added my first JIRA bug, Yipppehh! 1038
(normally I’m addicted to bugzilla)

rolf

MODX Staff
12,272 Posts

Ryan Thrash Reply #55, 17 years, 2 months ago

Hi stefan,

Could you please file improvement issues in JIRA so that we can properly track these through the development process. Both suggestions sure seem like a awesome updates.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

1,039 Posts

MadeMyDay Reply #56, 17 years, 2 months ago

just another answer for the auto-reply-mechanism and totally off-topic but nevertheless important:

STEFAN! you are back! Kind of... File it, man!

@Ryan: He is the man! Really! He is the one who can get Xedit started sooner... he is a kind of QA for us, and also for RC3 as you can see.But he needs more pressure obviously grin

MODx deutsch | Webdesign Karlsruhe | Ressourcen für Webdesign

☆ A M B ☆
1,231 Posts

yama Reply #57, 17 years, 2 months ago

This is automatic translation.

Hello, Ryan.

Because I am running out of time, I show only an improvement result. Please refer to it if good.

Click, {+}Modify button. You can see simple diff part.

http://code.google.com/p/modx-ja/source/detail?r=300
http://code.google.com/p/modx-ja/source/detail?r=298
http://code.google.com/p/modx-ja/source/detail?r=297
http://code.google.com/p/modx-ja/source/detail?r=294 (important!)
http://code.google.com/p/modx-ja/source/detail?r=293
http://code.google.com/p/modx-ja/source/detail?r=291
http://code.google.com/p/modx-ja/source/detail?r=279

...and...

http://www.youtube.com/watch?v=ZMKNV0KLzxs

thanks.

☆ A M B ☆
1,231 Posts

yama Reply #58, 17 years, 2 months ago

http://code.google.com/p/modx-ja/source/detail?r=307

☆ A M B ☆
1,231 Posts

yama Reply #59, 17 years, 2 months ago

DatePicker UI, time input field is too long.

MODX Staff
12,272 Posts

Ryan Thrash Reply #60, 17 years, 2 months ago

Quote from: yama at Jul 28, 2009, 10:01 PM

http://code.google.com/p/modx-ja/source/detail?r=300
http://code.google.com/p/modx-ja/source/detail?r=298
http://code.google.com/p/modx-ja/source/detail?r=297
http://code.google.com/p/modx-ja/source/detail?r=279

Please open proper bug reports for these and we’ll sort them out for 1.0.1 release.

The following have been implemented/fixed:
http://code.google.com/p/modx-ja/source/detail?r=294 (important!)
http://code.google.com/p/modx-ja/source/detail?r=307
http://www.youtube.com/watch?v=ZMKNV0KLzxs

The following should not be needed due to alternate implementations:
http://code.google.com/p/modx-ja/source/detail?r=293
http://code.google.com/p/modx-ja/source/detail?r=291

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me