[fixed] 0962-rc2 help tab generated to .svn folder

122 Posts

suvit Reply #1, 18 years, 1 month ago

used modx 0.9.6.2-rc2.
in the help page modx generated tabs for all files in the manager/help folder.
And for checkouted version modx generated tab for .svn folder, but this is incorrectly.

suvit
РROGWAY

MODX Staff
10,725 Posts

opengeek Reply #2, 18 years, 1 month ago

There shouldn’t be any svn folders involved. RC2 archives do not contain .svn folders. Are you saying you checked out trunk from SVN recently and this is happening on a working copy? If so, can you please record and track this issue in JIRA?

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

☆ A M B ☆
24,524 Posts

sottwell Reply #3, 18 years, 1 month ago

Yeah, if this is a check-out version, it would do that. The code needs to be edited to ignore those; in fact it should probably be edited to only use files, not folders. Here’s the code, in manager/actions/help.static.php:

if ($handle = opendir('help')) {
    while (false !== ($file = readdir($handle))) {
        if ($file != "." && $file != "..") {
            $help[] = $file;
        }
    }
    closedir($handle);
}

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

24,544 Posts

BobRay Reply #4, 18 years, 1 month ago

Maybe the help files should have a standard extension like .hlp. That way all extraneous files and directories (e.g. ftp_log, .svn, _svn, index.php, php.ini) can be ignored.

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

122 Posts

suvit Reply #5, 18 years, 1 month ago

Quote from: OpenGeek at Aug 13, 2008, 01:04 PM

There shouldn’t be any svn folders involved. RC2 archives do not contain .svn folders. Are you saying you checked out trunk from SVN recently and this is happening on a working copy? If so, can you please record and track this issue in JIRA?

Yes, i means checked out 0.9.6 branch, sorry for my english. Ok, I`m sign up in JIRA.
http://svn.modxcms.com/jira/browse/MODX-266

suvit
РROGWAY

MODX Staff
12,272 Posts

Ryan Thrash Reply #6, 17 years, 11 months ago

This should be fixed in the latest SVN and 0963 release.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

97 Posts

dflock Reply #7, 17 years, 8 months ago

Ok, so in 0.9.6.3 the code above was changed to this:

if ($handle = opendir('help')) {
    while (false !== ($file = readdir($handle))) {
        if ($file != "." && $file != ".." && $file != ".svn") {
            $help[] = $file;
        }
    }
    closedir($handle);
}

Is there a good reason that it wasn’t changed to something like this:

if ($handle = opendir('help')) {
    while (false !== ($file = readdir($handle))) {
        if (!is_dir($file) && $file[0] != '.') {
            $help[] = $file;
        }
    }
    closedir($handle);
}

This version will exclude all hidden files (*NIX convention, starting with a ’.’) and all folders. This seems like a neater more general solution than just adding another special case. What do you think?

Codeistry - custom website development & consultancy in Vancouver - experienced MODx developer for hire.