VersionX (basic versioning addon)

• • 
  • 297 Posts
  mIDO Reply #41, 15 years, 9 months ago

  There is no response, when I click it does nothing. I get a JS error: b is null from ext-all.js
• • ☆ A M B ☆
  • 3,141 Posts
  Mark Hamstra Reply #42, 15 years, 9 months ago

  What browser do you use?
  
  Perhaps you can try if it acts the same in a different one?
  
  It all works fine in my localhost on FF 3,6. IE8 seems to have trouble loading anything, looking in that now..
  
  
  Update: IE seems to break over some stuff labeled "class" and "new". Working on a fix for that..
  Mark Hamstra • Developer spending his days working on Premium Extras and a MODX Site Dashboard with the ability to remotely upgrade MODX and extras to make the MODX world a little better.
  
  Tweet me @mark_hamstra, check my infrequent blog at markhamstra.com, my slightly more frequent ramblings at MODX.today or see code at Github.
• • 
  • 297 Posts
  mIDO Reply #43, 15 years, 9 months ago

  Tested in Firefox 3.6.13 and Chrome 8.0.552.224
  IE8 does not load versionX at all.
  
  (error translation from spanish to english):
  An identifier was expected hometabs.panel.js Line:233
  Code: 0
  URI: http://www.mydomain.com/assets/components/versionx/js/hometabs.panel.js?v=204pl2
  An object was expected. Line 7. Char: 131072. Code: 0 ext-all.js
  
  
  MODx version: 2.0.4 pl2
  
• • 
  • 297 Posts
  mIDO Reply #44, 15 years, 9 months ago

  Error debug in Chrome ( on right click -> compare ):
  

  
  Uncaught TypeError: Cannot read property 'dom' of null
  Ext.extend.onRender/manager/assets/ext3/ext-all.js:7
  Ext.Panel.Ext.extend.onRender/manager/assets/ext3/ext-all.js:7
  Ext.grid.GridPanel.Ext.extend.onRender/manager/assets/ext3/ext-all.js:11
  Ext.extend.render/manager/assets/ext3/ext-all.js:7
  MODx.grid.Grid/manager/assets/modext/modext-min.js?v=204pl2:21
  VersionX.grid.Resources.Compare/assets/components/versionx/js/hometabs.panel.js?v=204pl2:314
  create/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.createComponent/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.lookupComponent/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.add/manager/assets/ext3/ext-all.js:7
  d/manager/assets/ext3/ext-all.js:7
  Ext.apply.each/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.Container.Ext.extend.add/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.initComponent/manager/assets/ext3/ext-all.js:7
  Ext.Panel.Ext.extend.initComponent/manager/assets/ext3/ext-all.js:7
  Ext.TabPanel.Ext.extend.initComponent/manager/assets/ext3/ext-all.js:7
  Ext.Component/manager/assets/ext3/ext-all.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  MODx.Tabs/manager/assets/modext/modext-min.js?v=204pl2:21
  create/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.createComponent/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.lookupComponent/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.add/manager/assets/ext3/ext-all.js:7
  d/manager/assets/ext3/ext-all.js:7
  Ext.apply.each/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.Container.Ext.extend.add/manager/assets/ext3/ext-all.js:7
  Ext.Container.Ext.extend.initComponent/manager/assets/ext3/ext-all.js:7
  Ext.Panel.Ext.extend.initComponent/manager/assets/ext3/ext-all.js:7
  Ext.Window.Ext.extend.initComponent/manager/assets/ext3/ext-all.js:7
  Ext.Component/manager/assets/ext3/ext-all.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  Ext.apply.extend.K/manager/assets/ext3/adapter/ext/ext-base.js:7
  comparewindow/assets/components/versionx/js/hometabs.panel.js?v=204pl2:245
  _contextMenu.Ext.menu.Menu.items.handler/assets/components/versionx/js/hometabs.panel.js?v=204pl2:159
  h.Event.fire/manager/assets/ext3/ext-all.js:7
  h.Observable.fireEvent/manager/assets/ext3/ext-all.js:7
  Ext.menu.BaseItem.Ext.extend.onClick/manager/assets/ext3/ext-all.js:11
  Ext.menu.Menu.Ext.extend.onClick/manager/assets/ext3/ext-all.js:11
  K
  

  
  
• • ☆ A M B ☆
  • 3,141 Posts
  Mark Hamstra Reply #45, 15 years, 9 months ago

  IE8 is fixed in Github. Will roll out alpha2 in a few hours, so I can hopefully resolve this first..
  
  I’m not yet sure what can be causing the compare not to work.
  
  
  It works fine for me in Chrome too on my localhost...
  Mark Hamstra • Developer spending his days working on Premium Extras and a MODX Site Dashboard with the ability to remotely upgrade MODX and extras to make the MODX world a little better.
  
  Tweet me @mark_hamstra, check my infrequent blog at markhamstra.com, my slightly more frequent ramblings at MODX.today or see code at Github.
• • 
  • 284 Posts
  novolo Reply #46, 15 years, 9 months ago

  Actually I’ve found out that it works fine in Chrome 9(b) but not in Opera 11.
  I’d look further into it later.
  MODX Free Template Base: MODX-Boilerplate | my blog (lots of MODX stuff) | my gitHub (translations) | MODX User Groups Germany (Facebook)
• • ☆ A M B ☆
  • 3,141 Posts
  Mark Hamstra Reply #47, 15 years, 9 months ago

  Thanks - much appreciated.
  
  If you end up with this error (slightly different worded):
  

  An identifier was expected hometabs.panel.js Line:233
  Code: 0
  URI: http://www.mydomain.com/assets/components/versionx/js/hometabs.panel.js?v=204pl2
  An object was expected. Line 7. Char: 131072. Code: 0 ext-all.js

  
  try fetching versionx from github instead of the package in the package manager. I fixed those errors (there were like 3 in total) already.
  
  I’m going to do my homework (due tomorrow) now and see if I see what’s missing later..
  
  
  Please do keep the bug reports and improvements coming (here or on Github).
  Mark Hamstra • Developer spending his days working on Premium Extras and a MODX Site Dashboard with the ability to remotely upgrade MODX and extras to make the MODX world a little better.
  
  Tweet me @mark_hamstra, check my infrequent blog at markhamstra.com, my slightly more frequent ramblings at MODX.today or see code at Github.
• • 
  • 297 Posts
  mIDO Reply #48, 15 years, 9 months ago

  Hi,
  I’ll try it later, nice job again!
  It’s different worded because I had to translate it myself ( spanish to english )...
  
  
• • 
  • 284 Posts
  novolo Reply #49, 15 years, 9 months ago

  Okay, update to alpha2 solves problem in Opera 11 and FireFox. Think it should be solved in all major browsers now.
  MODX Free Template Base: MODX-Boilerplate | my blog (lots of MODX stuff) | my gitHub (translations) | MODX User Groups Germany (Facebook)
• • ☆ A M B ☆
  • 3,141 Posts
  Mark Hamstra Reply #50, 15 years, 9 months ago

  Thanks for the confirmation!
  
  
  As I’ve just been given a sub forum for VersionX, I’d like to take discussion there.
  
  I don’t have the power to lock this topic, but just let’s pretend it’s closed, okay?
  
  
  New forum: http://modxcms.com/forums/index.php/board,396.0.html
  Mark Hamstra • Developer spending his days working on Premium Extras and a MODX Site Dashboard with the ability to remotely upgrade MODX and extras to make the MODX world a little better.
  
  Tweet me @mark_hamstra, check my infrequent blog at markhamstra.com, my slightly more frequent ramblings at MODX.today or see code at Github.

This discussion is closed to further replies. Keep calm and carry on.