[Revo] New Plugin: AutoFixImageSize

Please let me know if you experience serious performance problems! I’d love to improve the plugin!

i just noticed something - i have a small image on the template (26x32px - see attach) and AFIS want to resize it to 27x32px. is it a rounding or some other issue?

i also have an idea - how about limiting the image search to a specific <div>?
say only within <div class="maincontent"></div>

Quote from: krisj at May 20, 2011, 07:19 AM

i just noticed something - i have a small image on the template (26x32px - see attach) and AFIS want to resize it to 27x32px. is it a rounding or some other issue?

You should use such kind of images as a CSS background image, because it’s presentational only, no content.
Besides that, I can’t explain. The plugin compares the written values in width="" and height="" attributes with the physical size, taken from the PHP function getimagesize() ...

Quote from: krisj at May 20, 2011, 07:19 AM

i also have an idea - how about limiting the image search to a specific <div>?
say only within <div class="maincontent"></div>

That would require some additional Regular Expressions and HTML parsing. Not as easy as it sounds in the first moment... I’ll think about it.

Quote from: gerritvanaaken at May 20, 2011, 10:13 AM

Quote from: krisj at May 20, 2011, 07:19 AM

i just noticed something - i have a small image on the template (26x32px - see attach) and AFIS want to resize it to 27x32px. is it a rounding or some other issue?

You should use such kind of images as a CSS background image, because it’s presentational only, no content.
Besides that, I can’t explain. The plugin compares the written values in width="" and height="" attributes with the physical size, taken from the PHP function getimagesize() ...

Well, I wouldnt discount icon size images as not suitable for content. people generate all sorts of content...

maybe there is some sort of a bug in the way php is reading the image dimension in small files.

Quote from: gerritvanaaken at May 20, 2011, 10:13 AM

Quote from: krisj at May 20, 2011, 07:19 AM

i also have an idea - how about limiting the image search to a specific <div>?
say only within <div class="maincontent"></div>

That would require some additional Regular Expressions and HTML parsing. Not as easy as it sounds in the first moment... I’ll think about it.

no pressure and if it doesnt make it faster, then why bother.

discovered a little bug - when I use external images in the content eg: http://www.adobe.com/images/shared/download_buttons/get_flash_player.gif

it will also throw an error. i wonder what would be the best way to treat this?

skip the external img altogether?

I did not think about this before. Yes, I’ll need to skip external images.

update: New version is in the Package Management!

Very useful & elegant plugin!

I noticed that my clients often just set the "width"-value of the <img>-tag when using TinyMCE. The images don’t get resized then. I changed the plugin code at line 40:



to



Seems to work so far. Gerrit, do you expect problems with that?

Quote from: gerritvanaaken at May 30, 2011, 05:30 AM

I did not think about this before. Yes, I’ll need to skip external images.

update: New version is in the Package Management!

You could set system settings to also allow off-site use of phpthumb IIRC.

Perhaps it could become a plugin setting at a later release to also include external images (with a note on how to modify the required phpthumb settings)? If they start linking to external images and resizing them, I can definitely see a use in that.

@titanium Yea, that’s a good point! I’ll change that for the next RC!

@Mark H: Is this [[++setting_phpthumb_nohotlink_enabled]] ?

I’m not sure if getimagesize() works smoothly with external images...
http://php.net/manual/de/function.getimagesize.php

Need to test this, although I’m not sure if it’s the very best idea to support editors at hotlinking/copying images from remote locations...

it should work fine with external images. there might be more reliable and or performant alternatives though. perhaps something out of imagemagick’s toolset?

but using external images in general i think is something that should be considered very carefully.

one major use case is CDN. anyone played around with this yet?

another use case is images on subdomains for working around concurrency limitations in browsers. that why a configurable external ignore/filet option would be very useful.