[SOLVED] Another TV Bug: can not setValue of the existing TV

☆ A M B ☆
3,112 Posts

goldsky Reply #1, 15 years, 8 months ago

I attempt to set a hit counter TV by initiate a plugin:

<?php

switch ($modx->event->name) {
    case 'OnWebPageInit':
        break;
    case 'OnWebPagePrerender':
        $tv = $modx->getObject('modTemplateVar', array('name' => 'hits'));
        if ($tv->locked)
                return;
        $tvId = $tv->id;
        $count = $tv->getValue($tvId);
        $count++;
        $tv->setValue($tvId, $count);
        break;
    default :
        break;
}
return;

And it’s just not working.
Then I investigated all way down, and came up with this:

<?php

    public function setValue($resourceId= 0, $value= null) {
        $oldValue= '';
        if (intval($resourceId)) {
            $templateVarResource = $this->xpdo->getObject('modTemplateVarResource',array(
                'tmplvarid' => $this->get('id'),
                'contentid' => $resourceId,
            ),true);

            if (!$templateVarResource) {
                $templateVarResource= $this->xpdo->newObject('modTemplateVarResource');
            }

            if ($value !== $this->get('default_text')) {
                if (!$templateVarResource->isNew()) {
die(__LINE__ . ' : $value = ' . $value);
                    $templateVarResource->set('value', $value);
                } else {
die(__LINE__ . ' : $value = ' . $value);
                    $templateVarResource->set('contentid', $resourceId);
                    $templateVarResource->set('value', $value);
                }
                $this->addMany($templateVarResource);
            } elseif (!$templateVarResource->isNew()
                  && ($value === null || $value === $this->get('default_text'))) {
die(__LINE__ . ' : $value = ' . $value);
                $templateVarResource->remove();
            }
die(__LINE__ . ' : $value = ' . $value);
        }
    }

MyTV was not read as "if (!$templateVarResource->isNew()) {".
It died as the second die().

Or, do I miss something here?

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

24,544 Posts

BobRay Reply #2, 15 years, 8 months ago

I assume $this is an existing TV (if not, the get() calls will throw an error).

If the TV exists, isNew() will never be true.

FWIW, you should probably test the return from getObject() to make sure you really have one before trying to do anything with it. If it’s empty, any get() call will throw a PHP error.

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

☆ A M B ☆
3,112 Posts

goldsky Reply #3, 15 years, 8 months ago

$tvId = $tv->id;
returns the right ID of the TV.
So I assume, the object is not empty.

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

☆ A M B ☆
318 Posts

freejung Reply #4, 15 years, 8 months ago

I had the same issue, and eventually gave up and solved my problem in another way. I tried using the Save method but it still didn’t seem to save the new value.

I found a better way to do what I was trying to do anyway, but I’d be interested in the solution for this as it would be very handy to be able to change TV values with a plugin.

☆ A M B ☆
318 Posts

freejung Reply #5, 15 years, 8 months ago

Wait a second, goldsky, in your first code block, $tvId is the id of the template variable, right, not the current resource?

I think you want to use getValue($id) rather than getValue($tvId).

24,544 Posts

BobRay Reply #6, 15 years, 8 months ago

Why not just:

$templateVarResource->save();

Unless there’s some other reason to save the whole resource.

Then you shouldn’t need any add*() methods.

And why are you calling isNew() when you already know whether it’s new or not?

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

☆ A M B ☆
3,112 Posts

goldsky Reply #7, 15 years, 8 months ago

Quote from: esnyder at Jan 07, 2011, 03:01 PM

Wait a second, goldsky, in your first code block, $tvId is the id of the template variable, right, not the current resource?

I think you want to use getValue($id) rather than getValue($tvId).

You’re right.
Then I made some changes again, and then the HIT COUNTER now WORKS!
Thanks, guys!

<?php

switch ($modx->event->name) {
    case 'OnWebPageInit':
        break;
    case 'OnWebPagePrerender':
        $tv = $modx->getObject('modTemplateVar', array('name' => 'hits'));
        if ($tv->locked)
                return;
        $id = $modx->resource->id;
        $count = $tv->getValue($id);
        $count++;
        $tv->setValue($id, $count);
        $tv->save();
        break;
    default :
        break;
}

return;

PS:
The thing is still not working, is this plugin doesn’t not work for weblink.
I’m looking for the right event name for that.

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

24,544 Posts

BobRay Reply #8, 15 years, 8 months ago

It looks like OnWebPagePrerender is invoked in the modResponse class for every valid page, so it should work. Check the error log.

BTW, if you only connect the plugin to OnWebPagePrerender, you can get rid of the switch altogether since it will only execute for that event.

Did I help you? Buy me a beer
Get my Book: MODX:The Official Guide
MODX info for everyone: http://bobsguides.com/modx.html
My MODX Extras
Bob's Guides is now hosted at A2 MODX Hosting

☆ A M B ☆
3,112 Posts

goldsky Reply #9, 15 years, 8 months ago

Naahhh...
because it’ll be used for other things. grin

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

221 Posts

lx Reply #10, 15 years, 1 month ago

Hello goldsky,
I’ve tryed to use Your snipped, but it (onece the webpage is opened) it increases the value, but when i click on the next page it decreases the value huh

Do You know what can be the reason? I’m trying to set up a simple hit counter for my pages.
Of course the OnWebpagePrerender is selected and hits TV is setup

<?php

switch ($modx->event->name) {
    case 'OnWebPagePrerender':
        $tv = $modx->getObject('modTemplateVar', array('name' => 'hits'));
        if ($tv->locked)
                return;
        $id = $modx->resource->id;
        $count = $tv->getValue($id);
        $count++;
        $tv->setValue($id, $count);
        $tv->save();
        break;
    default :
        break;
}

return;

Lucas from AroundCyprus.net