MODX Staff
MODX Staff
Correct, it should simply accept the scriptProperties and leave them alone IMO.
I’m not sure I’m following you. Are you suggesting taking the $_POST array out of the processing in runProcessor() altogether? That would match what I was expecting to find there. I was surprised to find the $_POST being used at that level.
Correct, the $_GET and $_POST (and $_FILES) would override the scriptProperties...
At present, pre-merging the $scriptProperties won’t do anything if the $_POST array is unchanged, no?
Quote from: BobRay at Dec 13, 2010, 02:07 AMCorrect, it should simply accept the scriptProperties and leave them alone IMO.
I’m not sure I’m following you. Are you suggesting taking the $_POST array out of the processing in runProcessor() altogether? That would match what I was expecting to find there. I was surprised to find the $_POST being used at that level.
Because that’d be against the standards we’ve set (similar to Snippets), and $fields is improper, since the values passed in may not always be "fields".
☆ A M B ☆
<?php // highlight
$scriptProperties['name'] = $modx->getOption('name', $scriptProperties, $_POST['name']);
Sorry for jumping in the middle of discussion...
Are you guys talking about this?
<?php // highlight $scriptProperties['name'] = $modx->getOption('name', $scriptProperties, $_POST['name']);
☆ A M B ☆
<?php
$pagetitle = $modx->getOption('pagetitle', $scriptProperties, $_POST['pagetitle']);
$published = $modx->getOption('published', $scriptProperties, $_POST['published']);
$content = $modx->getOption('content', $scriptProperties, $_POST['content']);
$response = $modx->runProcessor('resource/create',array(
'pagetitle' => $pagetitle,
'published' => $published ,
'content' => $content,
/* etc */
));
if ($response->isError()) {
if ($response->hasFieldErrors()) {
$fieldErrors = $response->getAllErrors();
$errorMessage = implode("\n",$fieldErrors);
} else {
$errorMessage = 'An error occurred: '.$response->getMessage();
}
return $errorMessage;
}
return 'Success!';