Thirt Party Component removal deletes System Settings

This was registered under http://bugs.modx.com/issues/2739 as: Sample Site Removal Issue

The case why I want to start this Topic is that in my opinion a Third Party Component should not be able to delete System Settings completely.
In this case it was just my site Name and Error Page setting but imagine it deletes more than that making the site not accessible for Admins and visitors.

What happened:

Upon deleting the Sample Site I noticed the Site Name not being displayed in the Templates anymore.
Checking the site settings for this value made me end up with the conclusion that the fields are gone in the system settings.

Checking the former "Sample Site" with a "healthy" Revo site shows that at least the next values are missing:

Error Page
Site Name.

I didn’t check all the values on all the 5 pages but this definitely needs to be checked.

I reinstalled revo 2.0.4-pl2 and the values that went missing in the system settings now returned but with the default values which means the old settings got their values deleted in the database as well. (sometimes TV’s keep the values in the database even though the actual TV got removed)

This bug was registered and closed in redmine:
http://bugs.modx.com/issues/2739

Also see my other closed Bug report related to Removing the Sample Site here: http://bugs.modx.com/issues/2732

Both issues are now registered in GitHub but I believe the above "system settings" case belongs in Redmine.

Maybe It wasn’t clear in the above comment but the COMPLETE System Fields disappear/get deleted from the System settings pages, not only the values!

This is a problem with the Sample Site package, not the MODx core FWIW.

The trouble with preventing add-ons from removing System Settings on removal is that they often *create* System Settings on install and you wouldn’t want them to remain after the add-on is gone. That said, it might make sense to do something like designate the core System Settings as protected, so their values but not their keys or their existence can be modified.

Thanks for the replies.

Protecting System settings was what I was thinking of as well. This should be a feature request I guess to make System Fields and values protected.

It’s up to the MODx professionals to decide.

Thanks for your time!

Quote from: onepack at Nov 10, 2010, 03:29 PM

Thanks for the replies.

Protecting System settings was what I was thinking of as well. This should be a feature request I guess to make System Fields and values protected.

It’s up to the MODx professionals to decide.

Thanks for your time!

Feel free to file that as a feature request (using the Bugs & Requests link at the top of this page) so it won’t fall through the cracks.