We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 14883 ☆ A M B ☆
    • 450 Posts
    I installed RC1 over my beta 5 installation without too much trouble. When I logged in to Manager and tried to edit a resource, though, the ajax/shadowbox-overlay stuff would just hang with the ’loading’ message.

    I went to package mgr and installed the latest (rc1) versions of TinyMCE and CKEdit.

    When I was finished, CKEdit was now my chosen RTE (presumably because I installed it last). With CKEdit I was able to load resources and edit them. As a minor aside, though, the ’link’ stuff still doesn’t seem to be quite right. When you go to add a link in CKEdit, it takes you to browse your ’Files’, when I expect it to let me browse my ’Resources’. And if I just type in a link element into the form ([[~17]), it outputs into the html source code as http://[[~17].

    Wanted to go back to TinyMCE, so I went to system settings and set ’which_editor’ to TinyMCE. (Another aside; I had to type ’TinyMCE’ in freehand; I don’t remember doing that in the past & it seems like you’d want to use a pulldown menu for that).

    After selecting TinyMCE, the ajax/shadowbox/"loading" problem returned. In the error log I’m seeing this:

    [2010-03-24 10:55:10] (ERROR @ /srv/zenith/web_pages/wwwnew/core/components/tinymce/tinymce.class.php : 94) PHP warning: array_merge() [<a href=’function.array-merge’>function.array-merge</a>]: Argument #2 is not an array

    [2010-03-24 11:25:14] (ERROR @ /srv/zenith/web_pages/wwwnew/core/xpdo/xpdo.class.php : 1610) PHP warning: json_encode() [<a href=’function.json-encode’>function.json-encode</a>]: recursion detected

    The recursion error, to no one’s surprise, repeated about a billion times.

    I’ve seen that TinyMCE error before, while running beta 5. The line it refers to in the code is:
    $config = array_merge(array(
    ’path’ => dirname(__FILE__).’/’,
    ’language’ => $this->modx->getOption(’manager_language’,null,’en’),
    ),$this->config);

    Presumably this has to do with the way array_merge now requires all arguments to be arrays.

    As I’ve been composing this, I cleared my error log, and tried to recreate these errors again. Of course, now nothing is showing up in my error log, and the ajax/shadowbox/"loading" problem has mysteriously gone away. Resources are loading, and TinyMCE is working. (With the same problem that CKEditor has - using the Link URL browse feature takes you to Files rather than Resources.)

    So I guess everything is working pretty well now, with the exception of the RTE link stuff. I suppose I should have waited a while for the quirks to sort themselves out before composing this... but maybe the info will be useful in conjunction with the observations/experiences of others.



      • 28215
      • 4,149 Posts
      Quote from: jrotering at Mar 24, 2010, 11:54 AM

      I installed RC1 over my beta 5 installation without too much trouble. When I logged in to Manager and tried to edit a resource, though, the ajax/shadowbox-overlay stuff would just hang with the ’loading’ message.
      20 bucks says that was a problem with the JS from beta5 cached in your browser, and the reason it went away is because your browser cleared its cache.


      I went to package mgr and installed the latest (rc1) versions of TinyMCE and CKEdit.
      When I was finished, CKEdit was now my chosen RTE (presumably because I installed it last). With CKEdit I was able to load resources and edit them. As a minor aside, though, the ’link’ stuff still doesn’t seem to be quite right. When you go to add a link in CKEdit, it takes you to browse your ’Files’, when I expect it to let me browse my ’Resources’. And if I just type in a link element into the form ([[~17]), it outputs into the html source code as http://[[~17].
      Interesting - yeah, CKEditor seems to still be a bit buggy. Since that’s not in the MODx core anymore, though, we’ll roll out a new version (or someone else can pick it up) later.


      Wanted to go back to TinyMCE, so I went to system settings and set ’which_editor’ to TinyMCE. (Another aside; I had to type ’TinyMCE’ in freehand; I don’t remember doing that in the past & it seems like you’d want to use a pulldown menu for that).
      That is strange - you should be able to use a pulldown.


      After selecting TinyMCE, the ajax/shadowbox/"loading" problem returned. In the error log I’m seeing this:
      [2010-03-24 10:55:10] (ERROR @ /srv/zenith/web_pages/wwwnew/core/components/tinymce/tinymce.class.php : 94) PHP warning: array_merge() [<a href=’function.array-merge’>function.array-merge</a>]: Argument #2 is not an array
      This was fixed...is this an old TinyMCE version? That was definitely fixed in a later TinyMCE release.

      I’ll look into the recursion stuff and see if I can replicate it. I’ll also try and release a new TinyMCE version if I find a problem.

      I’m still willing to bet, though, that minus the recursion stuff, most of this was your browser cache having old JS in it.
        shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com
        • 14883 ☆ A M B ☆
        • 450 Posts
        I think you’re right that (most of) this was a cache issue. Editing the ’which_editor’ value is still showing up for me as a text field, though. Are others seeing that?
          • 28215
          • 4,149 Posts
          I can’t replicate it. You can always change the ’xtype’ value of that setting’s row to "modx-combo-rte" to revert it back.
            shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com
            • 14883 ☆ A M B ☆
            • 450 Posts
            I think this was just a matter of not using the primary/preferred method for updating a setting. When I double-click on the value in the system settings table, I do get a dropdown menu. Problem was, I had temporary amnesia about the fact that I could do this. Instead I was right-clicking and choosing "update setting", which brings up the overlay form, where the value field is always a plain text field.

            Sorry about the confusion.