We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 3749
    • 24,544 Posts
    Quote from: splittingred at Jan 15, 2010, 08:29 AM

    BobRay,

    Is this in SVN? If so, I can take a look at it.

    Yes, it’s there and matches my version. Thanks.
      Did I help you? Buy me a beer
      Get my Book: MODX:The Official Guide
      MODX info for everyone: http://bobsguides.com/modx.html
      My MODX Extras
      Bob's Guides is now hosted at A2 MODX Hosting
      • 28215
      • 4,149 Posts
      Hm, I couldn’t figure it out either...one thing though:

      foreach ($resources as $k => $resource) {
          $vehicle = $builder->createVehicle($resource,$attributes);
          if ($resource->get('pagetitle') == 'Thank You') {
              $modx->log(modX::LOG_LEVEL_INFO,'Packaging install script.<br />');
              $vehicle->resolve('php',array(
                  'type' => 'php',
                  'source' => $sources['build'] . 'install-script.php',
                  'target' => "return '" . $sources['build'] . "';"
              ));
          }
          $builder->putVehicle($vehicle);
      }
      

      Are you sure you want that PHP resolver executing for each Resource? That’s execing twice...
        shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com
        • 3749
        • 24,544 Posts
        Quote from: splittingred at Jan 15, 2010, 04:33 PM

        Hm, I couldn’t figure it out either...one thing though:

        foreach ($resources as $k => $resource) {
            $vehicle = $builder->createVehicle($resource,$attributes);
            if ($resource->get('pagetitle') == 'Thank You') {
                $modx->log(modX::LOG_LEVEL_INFO,'Packaging install script.<br />');
                $vehicle->resolve('php',array(
                    'type' => 'php',
                    'source' => $sources['build'] . 'install-script.php',
                    'target' => "return '" . $sources['build'] . "';"
                ));
            }
            $builder->putVehicle($vehicle);
        }
        

        Are you sure you want that PHP resolver executing for each Resource? That’s execing twice...

        Note the "if" statement. It only executes for the "Thank You" page (I hope).
          Did I help you? Buy me a beer
          Get my Book: MODX:The Official Guide
          MODX info for everyone: http://bobsguides.com/modx.html
          My MODX Extras
          Bob's Guides is now hosted at A2 MODX Hosting
          • 3749
          • 24,544 Posts
          @splittingred: The uninstall problem also occurs for Formit and Login as well as SPForm, but not for the Ditto and Wayfinder packages. I filed: http://svn.modxcms.com/jira/browse/MODX-1652.

          The only differences I can see are that Ditto and Wayfinder only have one element and don’t put any elements in categories.

          Let me know if the SPForm package has to be rebuilt after the fix (assuming that it’s not a problem with my environment).
            Did I help you? Buy me a beer
            Get my Book: MODX:The Official Guide
            MODX info for everyone: http://bobsguides.com/modx.html
            My MODX Extras
            Bob's Guides is now hosted at A2 MODX Hosting