getResources broken in 2.1.2-pl?

☆ A M B ☆
318 Posts

freejung Reply #31, 15 years, 2 months ago

Sorry, Jason, you are quite right, I hadn’t updated to the current version of getResources.

But when I did that it broke the code I had above, and I had to change the &parents parameter back to `1`.

If I leave out &parents, it tries to list all of the children of the current resource, and with &parents=`0` it times out before rendering, so I have no idea what the output is. Anyway, I now have the call working with 1.3.1 like this, which works fine for me:

[[getResources? &parents=`1` &resources=`[[*resource-docs]]` &sortby=`FIELD(modResource.id, [[*resource-docs]] )` &sortdir=`ASC` &tpl=`resource-docs.tpl` &tplFirst=`resource-docsFirst.tpl` &limit=`0` &includeTVs=`1` &processTVs=`1` &tvPrefix=``]]

Sorry for bugging you about it, I should have checked for the upgrade first.

MODX Staff
10,725 Posts

opengeek Reply #32, 15 years, 2 months ago

Your parents property should probably be set to -1 (or any invalid Resource id other than zero) unless you want to include children of the Resource with an id of 1 in addition to those you specified in the resources property. If you do not specify a parent, the current resource is used as the parents property, and if you specify 0, then all of the top level Resources (and their children up to the depth you specify) are included.

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

75 Posts

low Reply #33, 15 years, 2 months ago

Hello,

This is my contribution:

the getResources seems to be really broken with 2.1.2-pl (under 2.1.1-pl, no problem).

This part of code produce a list was work perectlty under 2.1.1-pl:

<div class="rubrique">
<h1>[[+pagetitle]]</h1>
<div class="description">[[+content]]</div>
[[!Getresources?&parents=`[[+id]]`&limit=`99`&includeTVs=`1`&processTVs=`1`&depth=`0`&sortby=`{"menuindex":"ASC"}`&tpl=`rubrique-liste.liste`]]
<p class="clear"></p>
  <div class="bas"><a href="/[[++cultureKey]]/[[~[[+parent]]]]" class="red">Retour à la catégorie précédente</a></div>
</div>

Under the 2.1.2-pl, this is what modx produce (html):

<div class="rubrique">
<h1></h1>
<div class="description"></div>

<p class="clear"></p>
  <div class="bas"><a href="/fr/catalogue/bottes-moto-forma/" class="red">Retour à la catégorie précédente</a></div>
</div>

But, when I add the [[+id]] outside the Getresources snippets, as:

<div class="rubrique rubrique-[[+id]]">
<h1>[[+pagetitle]]</h1>
<div class="description">[[+content]]</div>
[[!Getresources?&parents=`[[+id]]`&limit=`99`&includeTVs=`1`&processTVs=`1`&depth=`0`&sortby=`{"menuindex":"ASC"}`&tpl=`rubrique-liste.liste`]]
<p class="clear"></p>
  <div class="bas"><a href="/[[++cultureKey]]/[[~[[+parent]]]]" class="red">Retour à la catégorie précédente</a></div>
</div>

at line 1, bold is the added code : <div class="rubrique rubrique-[[+id]]">

The modx produce this html:

<div class="rubrique rubrique-11">
<h1></h1>
<div class="description"></div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_boulevard_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">BOULEVARD</p><p class="prix">143.50€</p><p class="description">NOUVEAUTE 2011</p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/botte-boulevard.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_urbantouchhidry_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">URBAN TOUCH HI-DRY</p><p class="prix">139.90€</p><p class="description">NOUVEAUTE 2011</p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/urban-touch-hi-dry.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_coverboot_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">COVER BOOT</p><p class="prix">32.00€</p><p class="description">Pratique et indispensable</p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/cover-boot.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_urbantouchlow_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">URBAN TOUCH LOW</p><p class="prix">129.50€</p><p class="description">NOUVEAUTE 2011</p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/urban-touch-low.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_downtown_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">DOWNTOWN</p><p class="prix">169.90€</p><p class="description">NOUVEAUTE 2011</p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/downtown.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_diabloxcape_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">DIABLO - XCAPE</p><p class="prix">158.00€</p><p class="description"></p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/diablo-xcape.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_flyevo_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">FLY EVO</p><p class="prix">124.00€</p><p class="description">Jusqu'à épuisement des stocks</p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/fly-evo.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_motion_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">MOTION</p><p class="prix">97.00€</p><p class="description">Jusqu'à épuisement des stocks</p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/motion.html" class="bouton3">fiche produit</a></div>
</div>
<div class="liste">
<div class="h"></div>
  <div class="m"><div class="left"><img src="/assets/components/phpthumbof/cache/_public_catalog_forma_boots-urbain_northwind_vignette.jpg.45fcf283a7e01a4cd00caedd1ad255ce.jpg" class="quimby_search_image"></div><div class="right"><p class="title">NORTHWIND</p><p class="prix">132.60€</p><p class="description"></p></div>
  <p class="clear"></p>
</div>
  <div class="b"><a href="/fr/catalogue/bottes-moto-forma/boots-urbain/northwind.html" class="bouton3">fiche produit</a></div>
</div>
<p class="clear"></p>
  <div class="bas"><a href="/fr/catalogue/bottes-moto-forma/" class="red">Retour à la catégorie précédente</a></div>
</div>

The presence of the [[+id]], before the call of the Getresources snippet produce what I want (and what 2.1.1-pl was produce)

Strange ! no ?

Low

MODX Staff
10,725 Posts

opengeek Reply #34, 15 years, 2 months ago

Remove the ! in your nested getResources snippet call — a bug fixed in 2.1.2 requires that you do not delay the processing of a Snippet in a Chunk tpl (the placeholders for each iteration of the Chunk go out of scope if you call something non-cacheable in the tpl).

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek