We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 24253
    • 125 Posts
    Few diffs, and some complete snippets included, which still have some FIXME’s regarding php notice errors

    index.php.diff is toplevel index.php smiley
      • 22303 MODX Staff
      • 10,725 Posts
      R.S., can you send me the complete php files, rather than the diffs? I’d rather let SVN handle the merging automatically.
        • 18397
        • 3,250 Posts
        Ditto. Also, which core snippets did you change?
          • 24253
          • 125 Posts
          Tsk tsk, not able to handle diff’s?

          But diff’s are handy to see which parts changed, thats why I posted it like this.

          But I’ll post the whole files, you’ll find the snippets in the snippets dir

          Remon

          P.S.
          Please, when you merge these files, have a look at the changes via websvn or something similar to see if you think the changes made sense...
            • 22303 MODX Staff
            • 10,725 Posts
            No worries -- I can handle diffs, but I’d prefer to use the SVN diff upon checkin; it’ll stop if there are any conflicts and pop-up diffs for me. This way, if anyone else made changes, I can handle the entire merge process without worrying about other conflicts.
              • 22303 MODX Staff
              • 10,725 Posts
              Ok Remon, your patches have been merged with some recent bug fixes and committed to SVN. Everything looks good, and my tests did not reveal any issues.
                • 24253
                • 125 Posts
                Ryan asked me how to show php notice errors

                In the top level (root) index.php find:

                $modx->stopOnNotice = false;
                


                change to:

                $modx->stopOnNotice = true;
                


                And if there’s a php notice error, it will be displayed smiley

                Thanks for merging the fixes, there were only few of them, though, if I recall correctly, the amount of database calls shown on the page will be increased due they weren’t recorded properly (or was it the time spent in mysql mode? Yeah, the time will in mysql mode will see increase cause it wasn’t calculated properly)

                However, my hosting provider’s server breaks the connection on too much php notice errors (which are surpressed by default in modx) with the strange behaviour I had that adding an extra include solved the "problem".


                Remon

                P.S.
                There are a few FIXME’s left in the parser, but I don’t think spending a lot of time to fix those is worth the effort.
                In the reorganized parser, these errors’ are gone allready, and disabling the error callback function alltogether on a running site is perhaps a better idea then the "MODX parse error" being displayed, no?
                I mean, the php error callback function is good for debugging purposes, but for a running site?
                Disabling it makes the script also a bit faster ;-)