We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 22668
    • 718 Posts
    Where I can read rules or standards about preparing changelog when committing?
    What should I do and what don’t?
    • For Evo, the main rule of thumb and the most important thing is to have every commit reference a JIRA issue number:
      * [#MODX-991]  Admin password form not appearing during install


      Typically the description will mirror the JIRA issue title, but when those are not entirely clear we may clarify them in the Changelog. They’re also loosely categorized into a few sections, so put ’em in the right spot, too:

      [*] Security:
      [*] Bugfixes:
      [*] Additional Improvements & Updates:

      Also, try to keep commits down to one issue per commit in case we need to revert a commit down the road.
        Ryan Thrash, MODX Co-Founder
        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
        • 22668
        • 718 Posts
        Oops.
        I was working with http://svn.modxcms.com/jira/browse/MODX-1878 issue and now I can’t close it.
        When I start working on this, I changed issue status to "In progress". And when I finished to work with it, I clicked to Stop progress. And got an error. I don’t have a screenshot of the first screen. But now, if I try to manually change the state of issue (by url) - I got error. See screenshot.
        I can’t close this issue or stop the progress.
          • 22668
          • 718 Posts
          One more question.
          For example, we have few updates:
          1. Language update.
          2. Typo in Language file.
          3. Typo in snippet description
          4. Missed bracket or any other punctuation.

          How do I choose what are these bugs? In which section I need to put the log info? In section that selected via Jira?

          1. Language update. (It is definitely Improvement)
          2. Typo in Language file. (Is it a bug or Improvement?)
          3. Typo in snippet description ?
          4. Missed bracket or any other punctuation. ?

          In change log we have typo fixes in both sections: in Bugfixes and in Additional Improvements & Updates.
            • 22668
            • 718 Posts
            • Quote from: Paprikas at Apr 27, 2010, 01:29 AM

              Help. Close this issue http://svn.modxcms.com/jira/browse/MODX-1878
              I can’t seem to do so either...wierd...
                • 22668
                • 718 Posts
                Today I receive one more error. But it closed fine.
                  • 22668
                  • 718 Posts
                  Looks like we don’t have clear rules here. Rules about code, changelog, doctypes, versioning for scripts and so on.
                  Here my own rules for now:
                  1. All typos, missed brackets and so on are bugs.
                  2. All NEW language strings or big updates are improvements.
                  3. All snippets, modules etc version number must be increased if any byte of code was changed. It is need to let people know that script was changed and they will update it.
                  4. New languages are features.

                  Also, sad about Jira categories. Some issues has been lost in ADDON, DITTO etc sections.
                  Found for myself very handy links.
                  All tickets sorted by update. http://svn.modxcms.com/jira/secure/IssueNavigator.jspa?mode=hide&requestId=10241
                  If someone post comment, ticket will be on top of the list.
                  Comments by rss http://svn.modxcms.com/jira/sr/jira.issueviews:searchrequest-comments-rss/10241/SearchRequest-10241.xml?tempMax=1000
                  • Good guidelines Max.
                    Quote from: Paprikas at Apr 27, 2010, 01:29 AM

                    Help. Close this issue http://svn.modxcms.com/jira/browse/MODX-1878

                    It’s somehow locked in the "In Progress" status and so it can’t be marked as resolved. I can’t get it to resolve either after assigning it to my user.
                    I can’t seem to do so either...wierd...
                      Ryan Thrash, MODX Co-Founder
                      Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                    • Victory!

                      Note for future: Administration > System > Integrity check (near bottom, left column) found and let me fix the issue status.
                        Ryan Thrash, MODX Co-Founder
                        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me