MODx#138 and name of language displayed

Due to the MODx#138, I have renamed the French folder in francais-utf8 to be conform to the most used character set in French for the manager. But now francais-utf8 is proposed as language for the installer >:( (and japanese-utf8 for japanese pepole).

IMHO, we mix the language and the character set. A french guy which want a site with a charset=iso-8859-1 could think that this choice done during the installation is definitive!. He don’t know that he could change later.

So, I haven’t checked that is it possible, but I suggest to keep the folder and file as "francais-utf8" or "japanese-utf8", but also filter the language label and displayed only "francais" or "japanese"

Thanks for your feedbacks about this remark.

Wouldn’t it make sense to always display language and encoding?

so, e.g.
français-utf8
français-latin1

etc.

Just for consistency’s sake... you don’t need to look up any files if you want to make sure which is which, and if there are multiple versions.

+1 on filtering the names.

IMHO, all of our language files should be UTF-8, since PHP doesn’t really handle any other encodings very well, other than ISO-8859-1. We should also be using the ISO country and language codes TBH. But we’ll try to address these for 0.9.7, since the language structure is changing significantly.

To benefit of the inheritance of the language selected by the user in the installer and to open the manager in the selected language, I have applied the Install-language-to-site-language patch proposed to solve the MOD#138 (done on rev 3766) but also modified the install/action.language to filter the extension (rev3766).

So now japanese-utf8 and francais_utf8 are displayed as japanese and francais. But japanese-utf8 and Francais-utf8 are always transmitted as POST to the following pages. And inherited in the manager, which now is opened in French (utf8) or in Japanese (utf8).

IMHO this means that when several characters sets exist for a language (like francais), the install/lang directory should contain mainly the utf8 version rather than any other character set.