Document Permissions Rewrite

I use document permissions extensively and I’ve been refining the code over the past couple days. All has been smooth but there’s one more thing that needs to be done, and requires an executive decision; one I don’t want to make myself So I’d like some input on how this should be handled.

I’ve been keeping a work log at #MODX-34 and 35. As described in the log, manager users can now only edit document permissions they have access to (manager or web). Right now (in my working copy), Any user with manager access permissions ([tt]access_permissions[/tt]) has the ability to make a document public, thus wiping both manager and web document access permissions.

An idea that I have would be to only allow Administrator (Role ID 1) users to make a document public. Is this a good idea or is there another reason for handling it the current way?

I’m not sure about limiting it only to Administrators, I dunno, it just seems a bit restrictive to me. My opinion is that we add a new permission for making documents public, that way it could be delegated out to roles other than Administrator (e.g. content managers vs. content editors)

Here’s another idea: Instead of limiting it only to Administrator, limit it to only users who have access to both web and manager document permissions?

Right now, I think it’s too late in the run of 0.9.6 to add a new permission to the already long list. I’m just thinking of best ways to handle this scenario with the current roles and permissions system.