TinyMCE in latest SVN (2464)

576 Posts

sirlancelot Reply #1, 19 years, 6 months ago

I see TinyMCE’s been upgraded to 2.1.0 (095 dev branch) and so has the plugin code. One thing that might not be right however are the include_once lines at the top.

include_once $modx->config['filemanager_path'].'assets/plugins/tinymce210/tinymce.lang.php';
include_once $modx->config['filemanager_path'].'assets/plugins/tinymce210/tinymce.functions.php';

They are using [tt]$modx->config[’filemanager_path’][/tt] which, in my configuration is the ’assets/’ directory. But the code defines this otherwise. So I end up with ’assets/assets/plugins/tinymce210/[...]’.

Is my configuration incorrect? Or should this be something different?

MODX Staff
10,725 Posts

opengeek Reply #2, 19 years, 6 months ago

It should be using the base_path property; can someone get this committed?

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

576 Posts

sirlancelot Reply #3, 19 years, 6 months ago

Updated: Rev 2465

Index: plugin.tinymce.tpl
===================================================================
--- plugin.tinymce.tpl	(revision 2464)
+++ plugin.tinymce.tpl	(revision 2465)
@@ -9,13 +9,13 @@
  *
  */
 
-include_once $modx->config['filemanager_path'].'assets/plugins/tinymce210/tinymce.lang.php';
-include_once $modx->config['filemanager_path'].'assets/plugins/tinymce210/tinymce.functions.php';
+include_once $modx->config['base_path'].'assets/plugins/tinymce210/tinymce.lang.php';
+include_once $modx->config['base_path'].'assets/plugins/tinymce210/tinymce.functions.php';
 
 // Set path and base setting variables
 if(!isset($tinyPath)) { 
 	global $tinyPath;
-	$tinyPath = $modx->config['filemanager_path'].'assets/plugins/tinymce210'; 
+	$tinyPath = $modx->config['base_path'].'assets/plugins/tinymce210'; 
 }
 $base_url = $modx->config['base_url'];
 $displayStyle = ( ($_SESSION['browser']=='mz') || ($_SESSION['browser']=='op') ) ? "table-row" : "block" ;

I promise that when I become more acquainted with the code I won’t ask such stupid questions

1,131 Posts

Bravado Reply #4, 19 years, 6 months ago

Good call! I don’t know why I didn’t think of that before!

Jeff

Jeff Whitfield

"I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."