MODX Staff
phX will not work in 0.9.7 period; this is why modInputFilter and modOutputFilter were created, so replace phX functionality for 0.9.7. Because of the ways in which the new parser works, the former phX approaches are no longer valid ways to apply these modifiers to placeholders.
In 0.9.7, It’s better to start using modOutputFilter instead of phx even if you could use it IMO.. takes off alot processing overhead and we can get the bugs ironed out sooner than later..
Array ( [0] => sidebar [1] => Hello? [2] => htmltag [3] => &width=100&height=100&borsize=1&format=Upper Case&tagname=div [4] => textareamini )
MODX Staff
Great news; thanks for digging in and giving it a try...
I’ve taken another look 0.9.7 (checked out rev2431 from braches/opengeek/trunk) and I’m quite impressed.
The conversion of my website of 405 documents went smoothly and the manager works.
Yep, though I think by centralizing all the logic in modTemplateVar class, we can now simplify that complexity. I’ll take a look at these issues, but I would bet they are related to specific widgets (which I never use, explaining why they aren’t tested and working properly)
Couple issues:
Weblinks do not work at all. It outputs the id of the document it should be linking to.
Template Variables return "Array" as the output.
I thought I’d take a look at the source code to try to fix the TV returning "Array" and I was awestruck at the complexity of it. After almost 30 minutes of tracing, I managed to print_r the array:It would seem the TV isn’t being passed through the widget parser or something ( I temporarily changed the widget to ’HTML Generic Tag’ it used to be un-used (no widget))....Array ( [0] => sidebar [1] => Hello? [2] => htmltag [3] => &width=100&height=100&borsize=1&format=Upper Case&tagname=div [4] => textareamini )
The problem also came up when I wasn’t using a widget at all. I don’t use widgets either but I thought I’d try one to make sure that not selecting a widget wasn’t the problem.
I’ll take a look at these issues, but I would bet they are related to specific widgets (which I never use, explaining why they aren’t tested and working properly)
☆ A M B ☆
class modSmarty extends Smarty {
var $modx= null;
function modSmarty(& $modx, $params= array ()) {
$this->__construct($modx, $params);
}
function __construct(& $modx, $params= array ()) {
parent :: __construct();
$this->modx= & $modx;
Warning: ksort() expects parameter 1 to be array, null given in /home/sites/sottwell.com/public_html/core/model/modx/modx.class.php on line 1525 Warning: Invalid argument supplied for foreach() in /home/sites/sottwell.com/public_html/core/model/modx/modx.class.php on line 1526
even just a plain [[Wayfinder]] call. I turned off friendly URLs and removed the .htaccess file to make sure.
19:36 < doze`> why do i see smarty in the commit logs.
19:36 <@ opengeek> rofl
19:37 <@ opengeek> because we are expermenting with using smarty to produce 100% customizable manager themes for 0.9.7
19:39 <@ opengeek> just as one possible approach, you could also build a theme with the regular MODx parser, but I wanted to
have physical files for a "default" manager that could not be "messed up" by dumping the db
19:39 <@ opengeek> the more important part is all the processors will now be separate from the presentation, so you can submit
content management requests from any context
19:40 < jon1012> opengeek: if you use smarty, try template inheritance
19:40 <@ opengeek> all AJAX accessible and complete with error messages
19:40 < jon1012> opengeek: I can send you the holdiland templates to see how it works
19:41 <@ opengeek> cool, yeah, shaun implemented this yesterday and today... it works wonderfully and the markup is instantly
XHTML compliant and to create a completely custom manager is a matter of copying the templates and modifying
them
19:42 < jon1012> hehe
19:42 < jon1012> well, with inheritanced no need of dcopying
19:42 < jon1012> never write the same line twice :)
19:42 <@ opengeek> yeah, I think he has it setup that way, but will confirm
19:42 < jon1012> I don't like the include top, include footer, etC...
19:43 < jon1012> with inheritance, you define zones, then call a template that will show them... but that template can do the
samer with an upper-level template...
19:44 <@ opengeek> well, here, the outer template is the modx controller (index.php) and is simply using a modSmartyParser class
to render the page templates
19:44 < jon1012> ok
19:45 <@ opengeek> next step is to break the framed model down into the theme as well (i.e. can delgate to theme-specific
controllers or outer templates)
Anyone with rights, feel free to split this if you agree.
MODX Staff
