Ditto 2.0 Alpha 2

3,250 Posts

MARKSVIRTUALDESK Reply #11, 19 years, 8 months ago

Fixed.

MODX Staff
12,272 Posts

Ryan Thrash Reply #12, 19 years, 8 months ago

Quote from: heliotrope at Jan 15, 2007, 05:02 PM

Looks pretty fast
Much more than my changes

Out of curiosity heliotrope, care to share how much faster it is than earlier iterations including your tweaks along the way?

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

2,542 Posts

heliotrope Reply #13, 19 years, 8 months ago

more than 1s

MySQL: 0.3781 s, 15 request(s), PHP: 1.7009 s, total: 2.0790 s, document retrieved from database.

Made with MODx : [url=http://www.copadel.com]copadel, fruits et l

2,542 Posts

heliotrope Reply #14, 19 years, 8 months ago

same db as the last thread where I was close to the 3s.

Even when filters are on the results are under 3s

Nice isn’t it

:-)

Made with MODx : [url=http://www.copadel.com]copadel, fruits et l

2,542 Posts

heliotrope Reply #15, 19 years, 8 months ago

I’ve made another comparison with the same call to retrieve all the content without filters.
Here are the results:

The call:

[!Ditto? &parents=`0` &summarize=`198` &paginate=`1` &tpl=`photolist2` &debug=`0` &depth=`4` &sortBy=`menuindex` &sortDir=`ASC` !]

Total doc: 4930

ditto with my changes:
MySQL: 0.4469 s, 13 request(s), PHP: 2.1183 s, total: 2.5652 s, document retrieved from database.

ditto Alpha 2
MySQL: 0.6044 s, 13 request(s), PHP: 0.5510 s, total: 1.1554 s, document retrieved from database.

:-)

Made with MODx : [url=http://www.copadel.com]copadel, fruits et l

2,542 Posts

heliotrope Reply #16, 19 years, 8 months ago

Hi Mark,

still testing ditto.
I’m trying to use the &tagData, &tags and &tagsDelimiter but can achieve to make it work correctly

[!Ditto? &parents=`0` &summarize=`198` &paginate=`1` &tpl=`photolist2` &debug=`0` &depth=`4` &sortBy=`menuindex` &sortDir=`ASC` &tagData=`tagsPhoto` &tagsDelimiter=`,` &tags=`viandes,legumes` !]

This call display the doc listing but a click on doc tag value (for instance viandes) doens’t remove from the result the doc with this tag equal to legume.

I’ve tried with &tags=`` in my call but ditto returns no documents found.

Am I missing something?

Thx for your help.

:-)

Made with MODx : [url=http://www.copadel.com]copadel, fruits et l

1,039 Posts

MadeMyDay Reply #17, 19 years, 8 months ago

Hi Mark,

just tested the 2.0alpha2. Two things don´t work for me:

1.) Quickedit buttons [+#content+] open the document manager in a popup, not the RTE. Link in the popup is (for example): domain.com/manager/index.php?a=112&id=1&doc=9&var=content

2.) The tplFirstRow chunk doesn´t seem to be parsed, ditto parses the default one (tpl).

Marc

MODx deutsch | Webdesign Karlsruhe | Ressourcen für Webdesign

2,542 Posts

heliotrope Reply #18, 19 years, 8 months ago

Hi Mark,

I’ve tested the tplAlt and it seems that even if tplFirst is not set the alt starts only at third doc.
Shoudn’t it start at the first (1,3,5,etc...).

@MadeMyDay

the name of the param is now tplFirst.

Any way I’ve also tested PHx integration with this tpl:

<div class="photoVig">
[+phx:if=`[+thumbImg+]`:is=``:then=``:else=`<span class="vignette"><a href="[~[+id+]~]"  >[+thumbImg+]</a></span>`+]
<h4 class="titPhoto"><a href="[~[+id+]~]">[+pagetitle+]</a></h4>
<p>Tags: [+tagLinks+] <br />date:[+createdon:date=`%d %m %Y %R %S`+]<p>
</div>

Everything works fine.

About my issue with tags I’ve changed the line 17 (file=extender/tagging.inc.php) to fix it

$givenTags = isset($_GET[$dittoID.'tags']) ? trim($_GET[$dittoID.'tags'].$delimiter.$tags) : trim($tags);

to

$givenTags = isset($_GET[$dittoID.'tags']) ? trim($_GET[$dittoID.'tags']) : trim($tags);

:-)

Made with MODx : [url=http://www.copadel.com]copadel, fruits et l

3,250 Posts

MARKSVIRTUALDESK Reply #19, 19 years, 8 months ago

Replace this:

if (($x + 1) % 2) {

in the template class with:

if ($x % 2) {

3,250 Posts

MARKSVIRTUALDESK Reply #20, 19 years, 8 months ago

Heliotrope: Try replacing the troublesome line with these:

$getTags = isset($_GET[$dittoID.'tags']) ? trim($_GET[$dittoID.'tags']) : "";
	// Get tags from the $_GET array
	
$givenTags = isset($tags) ? trim($tags.$delimiter.$getTags) : trim($getTags);
	// given tags from the get array