Quote from: TobyL at Dec 22, 2006, 08:00 PM
I must say I don’t understand half of what you’ve done Jason (but I’m sure I’ll get there in the end). Excellent work.
I did a fresh install on winXp sp2, mysql 5.0 and php 5.2.0 without PDO extension - All very smooth! Added the php PDO extension and again all seems to work as intended (possibly even smoother )
However, when I browsed through the demo pages I came across an anomaly in the Contact Us page. The page displayed and extra `]] at the top of the page. Have a look yourself. The page has 2 snippets, the old contactform and eForm. hen deleting the old contactform snippet the problem goes away.
After experimenting a bit I figured out that adding snippet calls to a page can produce unexpected results when saving as well:
[[snippetName? ¶m=`value`]]
Saves fine.
[!snippetName? ¶m=`value`!]
Saves fine.
[[snippetName? ¶m=`value`]]
[!snippetName? ¶m=`value`!]
Saving not Ok.. ends up like last ] stripped i.e.:
[[snippetName? ¶m=`value`]]
[!snippetName? ¶m=`value`!
It should definitely work smoother with PDO, considering I wrote a PDO emulation layer that works in PHP 4 and 5 when PDO is not installed and configured. If I can find a way to use my PDO emulation when the requested PDO driver is not available, that would be even cooler, but so far, that’s not looking like a good possibility...
As for the wierd content on the contact page, this is just the default content from 0.9.5 and will be completely replaced very soon, by content that is coded specifically for the new simplified tag format. All tags for the new parser are now [[ ]] with the kind of component determined by the first few tokens in the string:
[[snippet]]
[[!nonCacheableSnippet]]
[[$chunk]]
[[*tvsAndResourceMeta]]
[[!*nonCacheableTV]]
[[!#*nonCacheableTVwithQE]]
[[+placeholder]]
[[++configSettings]]
[[~links]]
Legacy tags are converted to this format as the content is parsed.
And yeah, I’m not really sure what is going on with saving, but I have all kinds of code being stripped when saving it through this version of the manager. I’ll bet anything it is related to the fact that the manager is running on the new MODx core and possibly applying the front-end request cleansing to the back-end. I’ll dig into that more today.