We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 22303 MODX Staff
    • 10,725 Posts
    Apparently, Wayfinder is assuming that any SVN revision higher than 1392 is going to have the link_attributes column in the database. This is not an acceptable measure of features/versions with MODx, because the revision numbers are sequential while our releases, like the 0.9.2.2 security patch/update do not necessarily fit this sequence. We need to come up with a way to determine features based on the major, minor, and patch level version numbers, not the SVN revision.

    As a result, anyone using Wayfinder 1.0 (not sure when the check was added to Wayfinder) will break their site when applying the 0.9.2.2 patch or upgrade. I’m working on a quick fix to get people running, but I need this to be addressed so future releases like this will not break components that are checking for specific versions/features.
      • 15987
      • 786 Posts
      Sorry about that, I hadn’t thought about what would happen when there were updates to previous releases. I will get the update put into Wayfinder asap and add it to the repository.
        • 15987
        • 786 Posts
        Jason,
        I have been trying to find a way to better implement this version checking and have temporarily applied your fix for it.

        I am currently getting the info from the api call $modx->getVersionData()

        and it gives me back the following values:

        Array
        (
            [code_name] => rev 1754
        [version] => 0.9.5 beta 5
        [small_version] => 0
        [patch_level] => 0
        [full_appname] => MODx 0.9.5 beta 5 (rev 1754)
        )
        <br /><br />With this info it is quite hard to get an accurate version number for checking, and was wondering if we could add the following to it:<br /><br />

        Array
        (
        [code_name] => rev 1754 [version] => 0.9.5 beta 5 [major_version] => 0 [minor_version] => 9 [small_version] => 5 [patch_level] => 0 [full_appname] => MODx 0.9.5 beta 5 (rev 1754) )


        Or something along those lines so that the version does not need to be parsed out for a feature check like I am doing in Wayfinder.

        just some thoughts on what might make this easier,

        Kyle
          • 22303 MODX Staff
          • 10,725 Posts
          Right, that’s exactly the problem. I thought we had the major, minor, small, and patch numbers isolated before; not sure what happened to that, but...without that being consistent going back to these already released versions, I’m not sure how to reconcile the ability we are looking for with the reality of this data.

          I don’t think it’s urgent, so let’s deliberately wait on this a little more before we decide on the final solution.
            • 25663 MODX Staff
            • 12,272 Posts
            Perhaps we can just add a param to force a specific mode...
              Ryan Thrash, MODX Co-Founder
              Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
              • 22303 MODX Staff
              • 10,725 Posts
              Quote from: rthrash at Nov 07, 2006, 10:35 AM

              Perhaps we can just add a param to force a specific mode...
              Yes, but we also need a valid way to determine and compare versions of both components and the core so these kinds of checks can be handled automatically by developers in cases where it makes sense.