MODX Staff
Let’s fix the template switcher plugin and not distribute Disable Cache. Anyone care to give it a quick go?Commit #1818
All I’ve done is implemented the one line of code from the Disable Cache plugin in the TemplateSwitcher plugin and updated the necessaries in the install. I’ve also modified the install so that it sets up the &useCookie config option for the plugin automatically.
☆ A M B ☆
Commit #1818
$modx->documentObject['cacheable'] = 0;
MODX Staff
Of course, this will break if you later switch from/to friendly URLs, but you can at least then go back and change the links in your internal weblinks if you have to.
Paul and Toby: how’s the permissions review and overhaul coming (nice addition a few posts back Toby).
When I regenerated the lang files, I mistakenly didn’t include the include-English bit, because all the language strings were there at that time (as the English text was added to the foreign files) and to be honest I wasn’t expecting many extra strings to be added. This does need readding, and would presumably stop snippets from failing.
Finally, there’s been more additions and alterations to the language files so it might behoove us to slim down the number of default languages to ensure we have complete sets and no snippets fail. (Speaking of which, all languages should default back to English if the native one is not available I suppose ... but do they?) If we need to trim some languages out for the release, which ones are critical other than English and French (since I know those two are effectively complete now)?
I don’t actually understand what the point of "Close Doc Manager" is. No other screen has this, although they do have "Cancel". In other screens, "Cancel" takes you to home/welcome page (although Polls Module goes to the Manage Modules screen). So, it would seem that the most consistent thing is "Cancel" > home/welcome.
@Doc Manger: Garry, if we make "Close Doc Manager" to go on home/welcome page, instead of "Manage Modules"
I think all that will do is prevent the "new" version of the document from being cached, it will not stop the parser from getting an already cached version (with the original template) and ignoring the template switch, since if there’s a cached version it stop parsing.
MODX Staff
Getting template switching to work would be very very cool. This is a very MODx thing. It would also make it easier to have a parallel mobile/PSP/webTV site from the same document data.I like the idea a lot, but do not think it’d be wise to delay 095 for this. But this also raised a question I’d not previously considered: Are the alternate templates for every web surfer, or just for the per-visitor choice?
But the caching is also crucial to MODx. So... simple idea.. don’t know how easy it is to code, but it seems the logical solution:
Change the caching to save out on a per-document AND per-template basis. Parser looks for a cached version of that document/template combination; if it’s there, uses it, if it’s not, parses and saves. Simple. Logical. What people might expect. I can’t really see any point expending energy on any bundled solution that isn’t this.
(I know that’s a fairly major change to the core, but it would open up a few things, not least simplifying my upcoming PDF plugin).
MODX Staff
When I regenerated the lang files, I mistakenly didn’t include the include-English bit, because all the language strings were there at that time (as the English text was added to the foreign files) and to be honest I wasn’t expecting many extra strings to be added. This does need readding, and would presumably stop snippets from failing.Makes sense and agreed. There will be even more language additions as bug reports of other hard coded strings get committed over the weekend (likely within 12 hours).
While there is some logic behind not including incomplete language files in the download, if a German upgrades from 0.9.2.1 or from a 0.9.5 beta, he’ll have his old lang file, which is probably worse than a lang file that we’ve tested and upgraded. So "every language that has previously been released" is critical.
I don’t actually understand what the point of "Close Doc Manager" is. No other screen has this, although they do have "Cancel". In other screens, "Cancel" takes you to home/welcome page (although Polls Module goes to the Manage Modules screen). So, it would seem that the most consistent thing is "Cancel" > home/welcome.Fair enough and convinced. Let’s make it consistent across the board though... and remove the close button if possible (but there may be a reason for it?).
MODX Staff
Quote from: rthrash on Yesterday at 12:33 AM
Paul and Toby: how’s the permissions review and overhaul coming (nice addition a few posts back Toby).
Unfortunately I’ve not been well *and* I’ve been particularly busy at work. I will be able to sort this all out by Monday.
This discussion is closed to further replies. Keep calm and carry on.