-
☆ A M B ☆
- 24,524 Posts
The latest svn installer has the new field for link_attributes in the database (immediately following the alias field), but the data to upload for the default pages don’t have that field covered.
-
MODX Staff
- 12,272 Posts
Good catch. Can you fix that?
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
Actually, if you’re going to change setup.data.sql can you hold on a mo while I list the minor grammatical and spelling mistakes in it?
Spelling/Grammar changes
Line 33: (doc 1) "Scrip.aculo.us" should be "Script.aculo.us"
Line 52: (doc 1) "Priveleges" should be Privileges
Line 72: (doc 32) "based off of" arguably should be "based on"; "type styling guildlines" should be "type styling guidelines";
Line 137: (chunk 9) "Your Sites Slogan" should be "Your Site\’s Slogan"
Of course, there’s quite a lot that needs changing as we move to Ditto, Wayfinder and Replix.
Whilst going through looking for errors, I made some notes:
SNIPPETS USED BY DEFAULT CONTENT (AND CHUNKS REFERENCED BY THEM)
Line 36: (3) NewsPublisher {FormBlog, FormBlogComments}
Line 39: (2) NewsListing {FormBlogComments, nl_blog}
Line 42: (4) WebLogin
Line 45: (6) ContactForm
Line 48: (7) DropMenu, FlexSearchForm
Line 51: (5) WebSignup {FormSignup}
Line 54: (8) FlexSearchForm
Line 60: (11) NewsListing {FormBlogComments}
Line 66: (15) DropMenu
Line 90: (15) WebLogin {FormLogin}
Line 96: (39) DropMenu
Line 140: {10} UserCommentCount, UserComments
Line 200: t3 DropMenu
Line 203: t1 DropMenu, DropMenu, AjaxSearch, NewsListing, WebLogin
Line 206: t4 NewsListing, ListIndexer, WebLogin, AjaxSearch, MODxHostMenu
Line 57: {9} {FormBlogComments}
Line 87: {26} {FormBlogComments}
Line 96: (39) {styles}
which are hopefully useful. Includes (docID) {chunkID} etc.
Finally, while on the subject of the default content..
Reduce length of QuickEdit page!!
I think the QuickEdit page is excessive. This page takes up 8kb and gives a lot of information that is duplicated in the manager and the "Help" page that QE links to. By the time anyone wants to refer to the advanced information they will have cleared out the example data anyway! A short page saying "Look top left! See the manager or the forum for more information on adding elements to the QuickEdit bar." would suffice.
This default pages issue also affects the single "MODx CMS Install Success" page added for people who *don’t* choose the default content, so this makes the current SVN uninstallable as-is.
Add ’’, after ’minimal-base’, on line 741 of setup.sql - and similarly after every alias in the default content.
-
☆ A M B ☆
- 24,524 Posts
Quote from: rthrash at Aug 12, 2006, 10:37 AM
Good catch. Can you fix that?
I was going to zip up and attach the files I used for installing my new site, but it’s running php suexec and quite happily deleted my install folder! So I’ll take a few minutes and do it again...
Keep in mind that the menu snippet will have to access this value to allow the developer to use it!
-
MODX Staff
- 12,272 Posts
Thanks Susan. Not tested but committed at 1273.
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
Should I add
Spelling/Grammar changes
Line 33: (doc 1) "Scrip.aculo.us" should be "Script.aculo.us"
Line 52: (doc 1) "Priveleges" should be Privileges
Line 72: (doc 32) "based off of" arguably should be "based on"; "type styling guildlines" should be "type styling guidelines";
Line 137: (chunk 9) "Your Sites Slogan" should be "Your Site\’s Slogan"
to Flyspray?
-
MODX Staff
- 12,272 Posts
Actually, can you use SVN? I’ll set up a branch for you pronto if so...
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
I have TortoiseSVN installed to look at stuff, I’ve never committed before but that’s only ’cos I’ve never had that kind of access anywhere. I’m sure I can figure it out. A branch would be fab, thanks. I’m PaulGregory on flyspray too if there’s anything you want to assign to me.