We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 22303 MODX Staff
    • 10,725 Posts
    Quote from: kylej at Aug 16, 2006, 04:47 PM

    weblinks will actualy display the link that has been inserted in the content field instead of using the weblink id to generate the link

    Is this optional per weblink? Or will you always get the URL to the final target with weblinks now?
      • 15987
      • 786 Posts
      I made it so that they will always display the final target... I can make it optional if you think that would be a better way to have it.
        • 25663 MODX Staff
        • 12,272 Posts
        I think the best call there Kyle is to make it option, but the default behavior. IOW, over-ridable if needed.

        On a related matter, I think it’d be handy to revisit (for the 0.9.5 release) adding the chunk/include configuration of the snippets. This would be a very cool addition I think that gains a lot from the portability, sharing, installation and flexibility standpoint. It’s being discussed in another context (debate over XML templating), but I think I make a pretty sound general argument for doing it this way:

        http://modxcms.com/forums/index.php/topic,6512.msg46428.html#msg46428

        Sound doable or logical for the next ultimate release?
          Ryan Thrash, MODX Co-Founder
          Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
          • 15987
          • 786 Posts
          I have completed what should be the version to include in the next release. I have attached it to this post and would love for any feedback. I will also get it commited for inclusin in the the install routine.

          This will only work if you have a modx version that includes Susan link attributes addition.

          I added the following:

          - Added category support, with additional template
          - Added active parent template
          - Added docid placeholder for output of docid
          - Added wf.classnames placeholder for output of just the class names
            • 22815
            • 1,097 Posts
            Quote from: kylej at Sep 06, 2006, 03:34 PM

            This will only work if you have a modx version that includes Susan link attributes addition.
            Is this true even if I’m not using link attributes in my template? If so, this pretty much makes it 0.9.5+ only, yes?

            Now that this has been made public in the 0.9.5 beta, where should feedback go? Can it be released into the Repo?
              No, I don't know what OpenGeek's saying half the time either.
              MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
              Forum: Where to post threads about add-ons | Forum Rules
              Like MODx? donate (and/or share your resources)
              Like me? See my Amazon wishlist
              MODx "Most Promising CMS" - so appropriate!
              • 15987
              • 786 Posts
              Yes this does make it only compatible with version 0.9.5+.

              I guess I could make it check which version the user is running and remove that column from the select statement.

              Does anyone know if there Is a way to test which version a user is running???


              I think we should probably wait until 0.9.5 is fully released before adding it to the repository, or the above fix is added for versions pre 0.9.5
                • 25663 MODX Staff
                • 12,272 Posts
                I’d say go ahead and add it, but mark it compatible only with 0.9.5 (and make that really clear/bold in the first line of the description).
                  Ryan Thrash, MODX Co-Founder
                  Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                  • 22815
                  • 1,097 Posts
                  Quote from: kylej at Sep 12, 2006, 09:47 AM

                  I guess I could make it check which version the user is running and remove that column from the select statement.

                  Does anyone know if there Is a way to test which version a user is running???
                  I don’t know about any official way, but I think it may be quicker and more flexible to set a variable in the Wayfinder snippet - "$Pre095CompatabilityMode" or somesuch near the top of the file. Then you could either bundle two versions of the snippet or tell older users that they need to change the line to make it work. This is then also flexible for any 0.9.x user that has added Susan’s column in another way.

                  The danger of not doing this is that you would end up needing to provide support for Wayfinder Beta2 AND the latest Wayfinder.
                    No, I don't know what OpenGeek's saying half the time either.
                    MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
                    Forum: Where to post threads about add-ons | Forum Rules
                    Like MODx? donate (and/or share your resources)
                    Like me? See my Amazon wishlist
                    MODx "Most Promising CMS" - so appropriate!
                    • 10487 MODX Staff
                    • 1,535 Posts
                    Garry Nutting Reply #89, 20 years ago
                    Does anyone know if there Is a way to test which version a user is running???
                    You could include version.inc.php (found in /managers/include) and extract the SVN revision number from $code_name and use that for a comparison.
                      Garry Nutting
                      Senior Developer
                      MODX, LLC

                      Email: [email protected]
                      Twitter: @garryn
                      Web: modx.com
                      • 15987
                      • 786 Posts
                      I have released a new version of wayfinder in the repository that checks the modx revision to make sure it can use link_attributes.

                      Thanks for the tip Garry smiley