Fix regClientStartupScript API

Guys, we need the fix from this post to be applied into our distribution package. I notice that the problem from the earlier version still persist on v0.9.2 & v0.9.2.1. Maybe someone with access to the SVN can commit this
http://modxcms.com/forums/index.php/topic,1942.msg18783.html#msg18783

Sincerely,

Thanks Wendy,

I’ll try to see if I can get it inside the trunk.

No problem Raymond.

Thanks.

@Raymond
The fix above don’t fix whole issue.. Be sure to look at the last page of that thread. OpenGeek knows some other problem with this too, I think it was that if called in cached page, even with uncached call, the first user that visits the page doesn’t get the scripts registered.. Maybe Jason can comment on this more, but anyways.. just to be sure that this will get fixed properly.

I’m not 100% sure because I tested this solution a couple months ago. But as far as I can remember, when I applied the fix from Adam and mine, everything is working just fine with this 4 different situation:
- uncached page - uncached snippet
- uncached page - cached snippet
- cached page - uncached snippet
- cached page - cached snippet

From what I can see from the current document parser code in v0.9.2.1, the fix had all been applied to the function regClientStartupScript, but the one that I have has not been fixed.

It’ll be best to test the above condition again before comitting the code.

Regards,

Ok I’ll double check this out but I think the new Parser should fix this problem. I’ll double check on this