Repository is Ready for Testing

3,975 Posts

Zaigham (aka zi) Reply #71, 20 years, 3 months ago

anyone know why:

<script type="text/javascript">var MODX_MEDIA_PATH = "media";</script>
<script type="text/javascript">var MODX_MEDIA_PATH = "media";</script>

appears twice in head tag ? Ryan ? tongue

Zaigham R - MODX Professional | Skype | Email | Twitter

Digging the interwebs for #MODX gems and bringing it to you. modx.link

MODX Staff
12,272 Posts

Ryan Thrash Reply #72, 20 years, 3 months ago

@Zi -- That’s been asked many times on the forums. That file is placed there in one of over 10(!) different places in the core. That logic needs some cleaning up indeed.

The problem with doing this is that it uses css for setting which image to use. Since we are using 0.9.1 and regclientCss does not work we would need to make some changes to how the css is added to the page. Not saying it can’t be done, but it might take some time to get workign right. I have seen some of the changes zi has made and it looks pretty good with the votes on there, imo.

We could easily patch that part I think.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

786 Posts

kjaebker Reply #73, 20 years, 3 months ago

Quote from: rthrash at Jun 26, 2006, 03:25 PM

We could easily patch that part I think.

If you can get that patched it would be great, take a look at the part zi has been working on and let us know if you mind having the vote count there. I think it looks pretty good with it included.

http://www.modxcms.com/Ditto-1.0-489.html

I have completed adding in support for the modx version compatibility.

and congrats on your 4000th post

MODX Staff
12,272 Posts

Ryan Thrash Reply #74, 20 years, 3 months ago

ugghh... i need a break! lol

We can add the CSS to the template itself, or we could just patch that part of the parser. Take yer pick.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

1,131 Posts

Bravado Reply #75, 20 years, 3 months ago

This might be a bug...then again it might not. I just attempted to add a resource and got the following error:

« MODx Parse Error »
MODx encountered the following error while attempting to parse the requested resource:
« `1` is not numeric and may not be passed to makeUrl() »

This is due to the website field having "http://" by default. If a user doesn’t enter anything else then it’ll error out. Probably should alter the script a bit to do a little error checking on this field.

Also, is it me or is the formatting screwed up on this page:

http://www.modxcms.com/TinyMCE-498.html

Jeff Whitfield

"I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."

MODX Staff
1,535 Posts

Garry Nutting Reply #76, 20 years, 3 months ago

Hi Jeff,

This might be a bug...then again it might not. I just attempted to add a resource and got the following error:

« MODx Parse Error »
MODx encountered the following error while attempting to parse the requested resource:
« `1` is not numeric and may not be passed to makeUrl() »

You’re right, it’s a bug! Thanks for catching

Also, is it me or is the formatting screwed up on this page

Yeah, it’s screwed up at the moment - Zi’s having a play with the theming, wish he’d stop tongue

j/k

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

3,975 Posts

Zaigham (aka zi) Reply #77, 20 years, 3 months ago

I am banging my head!!! with layout... tongue

I am fixing it, bear with me wink

@Ryan: 4000 posts! You should stop spamming and take a break.

*zi ran out quickly*

Zaigham R - MODX Professional | Skype | Email | Twitter

Digging the interwebs for #MODX gems and bringing it to you. modx.link

1,131 Posts

Bravado Reply #78, 20 years, 3 months ago

It’s ok, man. No need to bang your head. Sometimes it’s best to let thing lie, walk away a bit, and come back with a fresh mind. Even though we’re anxious as hell to see the repository go up, we understand these things can take time so... I’ll be patient and let ya fix all those little quirks as time allows. Personally, I’d rather see be done right than to rush it and see a bunch of bugs and quirks as a result. Granted, no app can be completely bug free...but if it’s damn close then I’m happy.

Jeff Whitfield

"I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."