QuickEdit : 3 hardcoded strings in outputclass.inc.php remaining

7,075 Posts

davidm Reply #1, 20 years, 7 months ago

Unless I am mistaken, there is still three hardcoded strings in outputclass.inc.php line 141 :

  $menus = array('content'=>array(), 'settings'=>array(), 'go'=>array());

and once you’ve replace array, settings, go , you have to replace all instances in line 143, 148, 154, 159, 178, 180. I have tried with french strings and it works.

If I am correct, we had to add those to the language strings and modify this line accordingly...
Should I file this in FlySpray ?

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

MODX Staff
12,272 Posts

Ryan Thrash Reply #2, 20 years, 7 months ago

Please add to FS. Thanks.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

7,075 Posts

davidm Reply #3, 20 years, 7 months ago

Will do later today ! I don’t know how I missed this one for so long... probably something having to do with the fact I use more english in a day than french I just don’t "see" the language difference... lol

My mistake, it was not in the enligsh language file so I did not include those in francais.inc.php.
I’ll correct that.

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

680 Posts

aNoble Reply #4, 20 years, 7 months ago

Actually, I’m pretty sure they’re not hard-coded. Just add something like

$_lang['content'] = 'Content';
$_lang['setting'] = 'Settings';
$_lang['go'] = 'Go';

to your language file and that should take care of it.

Adam Crownoble: obleDesign.com | [email protected] | [email protected] (Google Talk)

7,075 Posts

davidm Reply #5, 20 years, 7 months ago

~~Ooops, sorry for the mistake Adam, I was not sure that’s why I asked... Only the $_lang[’content’] = ’Content’; was missing in the language file. I’ll add it and see if it works...~~

It makes me think of something : we should include all QuickEdit languages files in lang folder and ship it with the next version, don’t you think ?

Maybe post a request to translators in Internationalization forum about this....

Edit : Sorry, tried that (edit the francais.inc.php file and restored the outputclass.inc.php from the 0.9.1 distro).

It works the content/settings/go strings are properly translated but then I have no link appearing when I click "content", just "display/hide links" under settings (and not "document alias" and "publish/unpublish") and same for "go" I have only "log out" link and no manager and help link...

Strange huh

Sorry I have no php skills I can’t understand it (yet)... My "dirty" solution above worked though... I’ll dig and report

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

680 Posts

aNoble Reply #6, 20 years, 7 months ago

Well the way that the QuickEdit lang stuff works is that it will pull from either the lang file in assets/modules/quick_edit/lang/ or in manager/includes/lang/ so the translations can go in either place. I believe that the global lang overrides the module lang if there is a conflict. So the best thing is to just make sure that all of the translated terms are in the normal translation file.

The only reason I have a lang files in the module at all is so that if the QuickEdit can be upgraded with new features without having to hack the translation files.

Adam Crownoble: obleDesign.com | [email protected] | [email protected] (Google Talk)